Mirror
/
CyberChef
mirror of https://github.com/gchq/CyberChef.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

diff.mjs: Fixes tests and adds default flag 

* Sets default flag to `false` for `showSubtraction` flag.
    * Removes extra span for else case that was causing some tests to
    fail. Moreover, the previous behavior was defined as that.
    * Adds custom test for the showSubtraction option, both using the
    `showAdded` and `showRemoved` flags.
This commit is contained in:
Gustavo Silva 2019-10-29 23:35:35 +00:00
parent 726e117656
commit 9108b3923b
No known key found for this signature in database
GPG Key ID: 08551320BC3EDC50
2 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/operations/Diff.mjs
View File

@ -50,7 +50,7 @@ class Diff extends Operation {
{
"name": "Show subtraction",
"type": "boolean",
"value": true
"value": false
},
{
"name": "Ignore whitespace",
@ -123,7 +123,7 @@ class Diff extends Operation {
} else if (diff[i].removed) {
if (showRemoved) output += "<span class='hl3'>" + Utils.escapeHtml(diff[i].value) + "</span>";
} else if (!showSubtraction) {
output += Utils.escapeHtml(diff[i].value) + "</span>";
output += Utils.escapeHtml(diff[i].value);
}
}

24
tests/operations/tests/StrUtils.mjs
View File

@ -15,7 +15,29 @@ TestRegister.addTests([
recipeConfig: [
{
"op": "Diff",
"args": ["\\n\\n", "Character", true, true, false]
"args": ["\\n\\n", "Character", true, true, false, false]
}
],
},
{
name: "Diff added with subtraction, basic usage",
input: "testing23\n\ntesting123",
expectedOutput: "<span class='hl5'>1</span>",
recipeConfig: [
{
"op": "Diff",
"args": ["\\n\\n", "Character", true, true, true, false]
}
],
},
{
name: "Diff removed with subtraction, basic usage",
input: "testing123\n\ntesting3",
expectedOutput: "<span class='hl3'>12</span>",
recipeConfig: [
{
"op": "Diff",
"args": ["\\n\\n", "Character", true, true, true, false]
}
],
},