Remove unecessary `if: success()` from Github release workflow

This commit is contained in:
Ashleigh Carr 2024-02-06 10:29:20 +00:00
parent 7588e50f9f
commit dbdcb460e5
1 changed files with 0 additions and 7 deletions

View File

@ -37,17 +37,14 @@ jobs:
npm run testnodeconsumer npm run testnodeconsumer
- name: Production Build - name: Production Build
if: success()
run: npx grunt prod run: npx grunt prod
- name: UI Tests - name: UI Tests
if: success()
run: | run: |
sudo apt-get install xvfb sudo apt-get install xvfb
xvfb-run --server-args="-screen 0 1200x800x24" npx grunt testui xvfb-run --server-args="-screen 0 1200x800x24" npx grunt testui
- name: Image Metadata - name: Image Metadata
if: success()
id: image-metadata id: image-metadata
uses: docker/metadata-action@v4 uses: docker/metadata-action@v4
with: with:
@ -58,7 +55,6 @@ jobs:
type=semver,pattern={{version}} type=semver,pattern={{version}}
- name: Production Image Build - name: Production Image Build
if: success()
id: build-image id: build-image
uses: redhat-actions/buildah-build@v2 uses: redhat-actions/buildah-build@v2
with: with:
@ -74,7 +70,6 @@ jobs:
- name: Upload Release Assets - name: Upload Release Assets
if: success()
id: upload-release-assets id: upload-release-assets
uses: svenstaro/upload-release-action@v2 uses: svenstaro/upload-release-action@v2
with: with:
@ -86,13 +81,11 @@ jobs:
body: "See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details." body: "See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details."
- name: Publish to NPM - name: Publish to NPM
if: success()
uses: JS-DevTools/npm-publish@v1 uses: JS-DevTools/npm-publish@v1
with: with:
token: ${{ secrets.NPM_TOKEN }} token: ${{ secrets.NPM_TOKEN }}
- name: Publish to GHCR - name: Publish to GHCR
if: success()
uses: redhat-actions/push-to-registry@v2 uses: redhat-actions/push-to-registry@v2
with: with:
image: ${{ steps.build-image.outputs.image }} image: ${{ steps.build-image.outputs.image }}