handle CannotCreateContactForReverseAlias when user creates a new contact

app/api/views/alias.py

@@ -21,6 +21,7 @@ from app.db import Session
 from app.email_utils import (
     generate_reply_email,
 )
+from app.errors import CannotCreateContactForReverseAlias
 from app.log import LOG
 from app.models import Alias, Contact, Mailbox, AliasMailbox
 from app.utils import sanitize_email
@@ -416,13 +417,16 @@ def create_contact_route(alias_id):
     if contact:
         return jsonify(**serialize_contact(contact, existed=True)), 200
 
-    contact = Contact.create(
-        user_id=alias.user_id,
-        alias_id=alias.id,
-        website_email=contact_email,
-        name=contact_name,
-        reply_email=generate_reply_email(contact_email, user),
-    )
+    try:
+        contact = Contact.create(
+            user_id=alias.user_id,
+            alias_id=alias.id,
+            website_email=contact_email,
+            name=contact_name,
+            reply_email=generate_reply_email(contact_email, user),
+        )
+    except CannotCreateContactForReverseAlias:
+        return jsonify(error="You can't create contact for a reverse alias"), 400
 
     LOG.d("create reverse-alias for %s %s", contact_addr, alias)
     Session.commit()

app/dashboard/views/alias_contact_manager.py

@@ -16,6 +16,7 @@ from app.email_utils import (
     generate_reply_email,
     parse_full_address,
 )
+from app.errors import CannotCreateContactForReverseAlias
 from app.log import LOG
 from app.models import Alias, Contact, EmailLog
 
@@ -184,41 +185,29 @@ def alias_contact_manager(alias_id):
                     contact_name, contact_email = parse_full_address(contact_addr)
                 except Exception:
                     flash(f"{contact_addr} is invalid", "error")
-                    return redirect(
-                        url_for(
-                            "dashboard.alias_contact_manager",
-                            alias_id=alias_id,
-                        )
-                    )
+                    return redirect(request.url)
 
                 if not is_valid_email(contact_email):
                     flash(f"{contact_email} is invalid", "error")
-                    return redirect(
-                        url_for(
-                            "dashboard.alias_contact_manager",
-                            alias_id=alias_id,
-                        )
-                    )
+                    return redirect(request.url)
 
                 contact = Contact.get_by(alias_id=alias.id, website_email=contact_email)
                 # already been added
                 if contact:
                     flash(f"{contact_email} is already added", "error")
-                    return redirect(
-                        url_for(
-                            "dashboard.alias_contact_manager",
-                            alias_id=alias_id,
-                            highlight_contact_id=contact.id,
-                        )
-                    )
+                    return redirect(request.url)
 
-                contact = Contact.create(
-                    user_id=alias.user_id,
-                    alias_id=alias.id,
-                    website_email=contact_email,
-                    name=contact_name,
-                    reply_email=generate_reply_email(contact_email, current_user),
-                )
+                try:
+                    contact = Contact.create(
+                        user_id=alias.user_id,
+                        alias_id=alias.id,
+                        website_email=contact_email,
+                        name=contact_name,
+                        reply_email=generate_reply_email(contact_email, current_user),
+                    )
+                except CannotCreateContactForReverseAlias:
+                    flash("You can't create contact for a reverse alias", "error")
+                    return redirect(request.url)
 
                 LOG.d(
                     "create reverse-alias for %s %s, reverse alias:%s",