rename should_upgrade -> should_show_upgrade_button

app/models.py

@@ -232,7 +232,7 @@ class User(db.Model, ModelMixin, UserMixin):
 
         return False
 
-    def should_upgrade(self):
+    def should_show_upgrade_button(self):
         if self._lifetime_or_active_subscription():
             # user who has canceled can also re-subscribe
             sub: Subscription = self.get_subscription()

templates/header.html

@@ -6,7 +6,7 @@
       </a>
 
       <div class="d-flex order-lg-2 ml-auto">
-        {% if current_user.should_upgrade() %}
+        {% if current_user.should_show_upgrade_button() %}
           <div class="nav-item">
             <a href="{{ url_for('dashboard.pricing') }}" class="btn btn-sm btn-outline-primary">Upgrade</a>
           </div>