fix test

app/api/views/alias.py

@@ -18,7 +18,6 @@ from app.api.serializer import (
 )
 from app.dashboard.views.alias_log import get_alias_log
 from app.email_utils import (
-    is_valid_email,
     generate_reply_email,
 )
 from app.extensions import db
@@ -402,10 +401,10 @@ def create_contact_route(alias_id):
         return jsonify(error="Contact cannot be empty"), 400
 
     full_address: EmailAddress = address.parse(contact_addr)
-    contact_name, contact_email = full_address.display_name, full_address.address
+    if not full_address:
+        return jsonify(error=f"invalid contact email {contact_addr}"), 400
 
-    if not is_valid_email(contact_email):
-        return jsonify(error=f"invalid contact email {contact_email}"), 400
+    contact_name, contact_email = full_address.display_name, full_address.address
 
     contact_email = sanitize_email(contact_email)
 

email_handler.py

@@ -1100,8 +1100,8 @@ def get_mailbox_from_mail_from(mail_from: str, alias) -> Optional[Mailbox]:
         if mailbox.email == mail_from:
             return mailbox
 
-        for address in mailbox.authorized_addresses:
-            if address.email == mail_from:
+        for addr in mailbox.authorized_addresses:
+            if addr.email == mail_from:
                 LOG.d(
                     "Found an authorized address for %s %s %s", alias, mailbox, address
                 )

tests/api/test_alias.py

@@ -577,11 +577,11 @@ def test_create_contact_route_invalid_contact_email(flask_client):
 
     r = flask_client.post(
         url_for("api.create_contact_route", alias_id=alias.id),
-        json={"contact": "with space@gmail.com"},
+        json={"contact": "@gmail.com"},
     )
 
     assert r.status_code == 400
-    assert r.json["error"] == "invalid contact email with space@gmail.com"
+    assert r.json["error"] == "invalid contact email @gmail.com"
 
 
 def test_delete_contact(flask_client):