diff --git a/app/alias_suffix.py b/app/alias_suffix.py index 8f010fa8..c8e0d4ea 100644 --- a/app/alias_suffix.py +++ b/app/alias_suffix.py @@ -170,7 +170,7 @@ def get_alias_suffixes( if not default_domain_found: sl_domain = SLDomain.get(user.default_alias_public_domain_id) - if sl_domain: + if sl_domain and not sl_domain.hidden: prefix = ( "" if config.DISABLE_ALIAS_SUFFIX diff --git a/tests/test_alias_suffixes.py b/tests/test_alias_suffixes.py index 4ab4d09f..182f6c26 100644 --- a/tests/test_alias_suffixes.py +++ b/tests/test_alias_suffixes.py @@ -60,6 +60,30 @@ def test_get_default_domain_even_if_is_not_allowed(): assert suffixes[0].domain == default_domain.domain +def test_get_default_domain_hidden(): + user = create_new_user() + PartnerUser.create( + partner_id=get_proton_partner().id, + user_id=user.id, + external_user_id=random_token(10), + flush=True, + ) + user.trial_end = None + default_domain = SLDomain.filter_by( + hidden=True, partner_id=None, premium_only=False + ).first() + user.default_alias_public_domain_id = default_domain.id + Session.flush() + options = AliasOptions( + show_sl_domains=False, show_partner_domains=get_proton_partner() + ) + suffixes = get_alias_suffixes(user, alias_options=options) + for suffix in suffixes: + domain = SLDomain.get_by(domain=suffix.domain) + assert not domain.hidden + assert suffixes[0].domain != default_domain.domain + + def test_suffixes_are_valid(): user = create_new_user() PartnerUser.create(