Mirror
/
gitinspector
mirror of https://github.com/ejwa/gitinspector.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed pylint violations reported by a newer version of pylint.

This commit is contained in:
Adam Waldenberg 2015-10-12 03:15:30 +02:00
parent 34337dec17
commit 1f2f120389
12 changed files with 51 additions and 70 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gitinspector/basedir.py
View File

@ -22,7 +22,7 @@ import subprocess
import sys import sys
def get_basedir(): def get_basedir():
if hasattr(sys,'frozen'): # exists when running via py2exe if hasattr(sys, "frozen"): # exists when running via py2exe
return sys.prefix return sys.prefix
else: else:
return os.path.dirname(os.path.realpath(__file__)) return os.path.dirname(os.path.realpath(__file__))
@ -33,11 +33,11 @@ def get_basedir_git():
global __git_basedir__ global __git_basedir__
if not __git_basedir__: if not __git_basedir__:
sp = subprocess.Popen(["git", "rev-parse", "--is-bare-repository"], bufsize=1, bare_command = subprocess.Popen(["git", "rev-parse", "--is-bare-repository"], bufsize=1,
stdout=subprocess.PIPE, stderr=open(os.devnull, "w")) stdout=subprocess.PIPE, stderr=open(os.devnull, "w"))
isbare = sp.stdout.readlines() isbare = bare_command.stdout.readlines()
sp.wait() bare_command.wait()
if sp.returncode != 0: if bare_command.returncode != 0:
sys.exit(_("Error processing git repository at \"%s\"." % os.getcwd())) sys.exit(_("Error processing git repository at \"%s\"." % os.getcwd()))
isbare = (isbare[0].decode("utf-8", "replace").strip() == "true") isbare = (isbare[0].decode("utf-8", "replace").strip() == "true")
absolute_path = None absolute_path = None

6
gitinspector/blame.py
View File

@ -35,7 +35,7 @@ import threading
NUM_THREADS = multiprocessing.cpu_count() NUM_THREADS = multiprocessing.cpu_count()
class BlameEntry: class BlameEntry(object):
rows = 0 rows = 0
skew = 0 # Used when calculating average code age. skew = 0 # Used when calculating average code age.
comments = 0 comments = 0
@ -125,7 +125,7 @@ class BlameThread(threading.Thread):
PROGRESS_TEXT = N_("Checking how many rows belong to each author (Progress): {0:.0f}%") PROGRESS_TEXT = N_("Checking how many rows belong to each author (Progress): {0:.0f}%")
class Blame: class Blame(object):
def __init__(self, hard, useweeks, changes): def __init__(self, hard, useweeks, changes):
self.blames = {} self.blames = {}
ls_tree_r = subprocess.Popen(["git", "ls-tree", "--name-only", "-r", interval.get_ref()], bufsize=1, ls_tree_r = subprocess.Popen(["git", "ls-tree", "--name-only", "-r", interval.get_ref()], bufsize=1,
@ -178,7 +178,7 @@ class Blame:
@staticmethod @staticmethod
def get_time(string): def get_time(string):
time = re.search(" \(.*?(\d\d\d\d-\d\d-\d\d)", string) time = re.search(r" \(.*?(\d\d\d\d-\d\d-\d\d)", string)
return time.group(1).strip() return time.group(1).strip()
def get_summed_blames(self): def get_summed_blames(self):

8
gitinspector/changes.py
View File

@ -33,7 +33,7 @@ NUM_THREADS = multiprocessing.cpu_count()
__thread_lock__ = threading.BoundedSemaphore(NUM_THREADS) __thread_lock__ = threading.BoundedSemaphore(NUM_THREADS)
__changes_lock__ = threading.Lock() __changes_lock__ = threading.Lock()
class FileDiff: class FileDiff(object):
def __init__(self, string): def __init__(self, string):
commit_line = string.split("|") commit_line = string.split("|")
@ -65,7 +65,7 @@ class FileDiff:
return True return True
return False return False
class Commit: class Commit(object):
def __init__(self, string): def __init__(self, string):
self.filediffs = [] self.filediffs = []
commit_line = string.split("|") commit_line = string.split("|")
@ -93,7 +93,7 @@ class Commit:
def is_commit_line(string): def is_commit_line(string):
return string.split("|").__len__() == 4 return string.split("|").__len__() == 4
class AuthorInfo: class AuthorInfo(object):
email = None email = None
insertions = 0 insertions = 0
deletions = 0 deletions = 0
@ -169,7 +169,7 @@ class ChangesThread(threading.Thread):
__changes_lock__.release() # ...to here. __changes_lock__.release() # ...to here.
__thread_lock__.release() # Lock controlling the number of threads running __thread_lock__.release() # Lock controlling the number of threads running
class Changes: class Changes(object):
authors = {} authors = {}
authors_dateinfo = {} authors_dateinfo = {}
authors_by_email = {} authors_by_email = {}

20
gitinspector/comment.py
View File

@ -19,18 +19,18 @@
from __future__ import unicode_literals from __future__ import unicode_literals
__comment_begining__ = { "java": "/*", "c": "/*", "cc": "/*", "cpp": "/*", "cs": "/*", "h": "/*", "hh": "/*", "hpp": "/*", __comment_begining__ = {"java": "/*", "c": "/*", "cc": "/*", "cpp": "/*", "cs": "/*", "h": "/*", "hh": "/*", "hpp": "/*",
"hs": "{-", "html": "<!--", "php": "/*", "py": "\"\"\"", "glsl": "/*", "rb": "=begin", "js": "/*", "hs": "{-", "html": "<!--", "php": "/*", "py": "\"\"\"", "glsl": "/*", "rb": "=begin", "js": "/*",
"jspx": "<!--", "scala": "/*", "sql": "/*", "tex": "\\begin{comment}", "xhtml": "<!--", "jspx": "<!--", "scala": "/*", "sql": "/*", "tex": "\\begin{comment}", "xhtml": "<!--",
"xml": "<!--", "ml": "(*", "mli": "(*" } "xml": "<!--", "ml": "(*", "mli": "(*"}
__comment_end__ = { "java": "*/", "c": "*/", "cc": "*/", "cpp": "*/", "cs": "*/", "h": "*/", "hh": "*/", "hpp": "*/", "hs": "-}", __comment_end__ = {"java": "*/", "c": "*/", "cc": "*/", "cpp": "*/", "cs": "*/", "h": "*/", "hh": "*/", "hpp": "*/", "hs": "-}",
"html": "-->", "php": "/*", "py": "\"\"\"", "glsl": "*/", "rb": "=end", "js": "*/", "jspx": "-->", "html": "-->", "php": "/*", "py": "\"\"\"", "glsl": "*/", "rb": "=end", "js": "*/", "jspx": "-->",
"scala": "*/", "sql": "*/", "tex": "\\end{comment}", "xhtml": "-->", "xml": "-->", "ml": "*)", "mli": "*)" } "scala": "*/", "sql": "*/", "tex": "\\end{comment}", "xhtml": "-->", "xml": "-->", "ml": "*)", "mli": "*)"}
__comment__ = { "java": "//", "c": "//", "cc": "//", "cpp": "//", "cs": "//", "h": "//", "hh": "//", "hpp": "//", "hs": "--", __comment__ = {"java": "//", "c": "//", "cc": "//", "cpp": "//", "cs": "//", "h": "//", "hh": "//", "hpp": "//", "hs": "--",
"pl": "#", "php": "//", "py": "#", "glsl": "//", "rb": "#", "js": "//", "scala": "//", "sql": "--", "tex": "%", "pl": "#", "php": "//", "py": "#", "glsl": "//", "rb": "#", "js": "//", "scala": "//", "sql": "--", "tex": "%",
"ada": "--", "ads": "--", "adb": "--", "pot": "#", "po": "#" } "ada": "--", "ads": "--", "adb": "--", "pot": "#", "po": "#"}
__comment_markers_must_be_at_begining__ = {"tex": True} __comment_markers_must_be_at_begining__ = {"tex": True}

3
gitinspector/filtering.py
View File

@ -17,12 +17,9 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with gitinspector. If not, see <http://www.gnu.org/licenses/>. # along with gitinspector. If not, see <http://www.gnu.org/licenses/>.
from __future__ import print_function
from __future__ import unicode_literals from __future__ import unicode_literals
import re import re
import subprocess import subprocess
import terminal
import textwrap
__filters__ = {"file": [set(), set()], "author": [set(), set()], "email": [set(), set()], "revision": [set(), set()], __filters__ = {"file": [set(), set()], "author": [set(), set()], "email": [set(), set()], "revision": [set(), set()],
"message" : [set(), None]} "message" : [set(), None]}

26
gitinspector/format.py
View File

@ -84,23 +84,23 @@ def output_header():
else: else:
jquery_js = " src=\"https://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js\">" jquery_js = " src=\"https://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js\">"
print(html_header.format(title = _("Repository statistics for {0}").format(os.path.basename(basedir.get_basedir_git())), print(html_header.format(title=_("Repository statistics for {0}").format(os.path.basename(basedir.get_basedir_git())),
jquery = jquery_js, jquery=jquery_js,
jquery_tablesorter = tablesorter_js, jquery_tablesorter=tablesorter_js,
jquery_flot = flot_js, jquery_flot=flot_js,
jquery_flot_pie = pie_js, jquery_flot_pie=pie_js,
jquery_flot_resize = resize_js, jquery_flot_resize=resize_js,
logo = logo.decode("utf-8", "replace"), logo=logo.decode("utf-8", "replace"),
logo_text = _("The output has been generated by {0} {1}. The statistical analysis tool" logo_text=_("The output has been generated by {0} {1}. The statistical analysis tool"
" for git repositories.").format( " for git repositories.").format(
"<a href=\"https://github.com/ejwa/gitinspector\">gitinspector</a>", "<a href=\"https://github.com/ejwa/gitinspector\">gitinspector</a>",
version.__version__), version.__version__),
repo_text = _("Statistical information for the repository '{0}' was gathered on {1}.").format( repo_text=_("Statistical information for the repository '{0}' was gathered on {1}.").format(
os.path.basename(basedir. get_basedir_git()), localization.get_date()), os.path.basename(basedir. get_basedir_git()), localization.get_date()),
show_minor_authors = _("Show minor authors"), show_minor_authors=_("Show minor authors"),
hide_minor_authors = _("Hide minor authors"), hide_minor_authors=_("Hide minor authors"),
show_minor_rows = _("Show rows with minor work"), show_minor_rows=_("Show rows with minor work"),
hide_minor_rows = _("Hide rows with minor work"))) hide_minor_rows=_("Hide rows with minor work")))
elif __selected_format__ == "xml": elif __selected_format__ == "xml":
print("<gitinspector>") print("<gitinspector>")
print("\t<version>" + version.__version__ + "</version>") print("\t<version>" + version.__version__ + "</version>")

6
gitinspector/gitinspector.py
View File

@ -33,7 +33,6 @@ from output.responsibilitiesoutput import ResponsibilitiesOutput
from output.timelineoutput import TimelineOutput from output.timelineoutput import TimelineOutput
import atexit import atexit
import basedir import basedir
import blame
import changes import changes
import clone import clone
import config import config
@ -43,16 +42,13 @@ import format
import help import help
import interval import interval
import getopt import getopt
import metrics
import os import os
import optval import optval
import responsibilities
import sys import sys
import terminal import terminal
import timeline
import version import version
class Runner: class Runner(object):
def __init__(self): def __init__(self):
self.hard = False self.hard = False
self.include_metrics = False self.include_metrics = False

4
gitinspector/localization.py
View File

@ -77,10 +77,10 @@ def init():
def check_compatibility(version): def check_compatibility(version):
if isinstance(__translation__, gettext.GNUTranslations): if isinstance(__translation__, gettext.GNUTranslations):
header_pattern = re.compile ("^([^:\n]+): *(.*?) *$", re.MULTILINE) header_pattern = re.compile("^([^:\n]+): *(.*?) *$", re.MULTILINE)
header_entries = dict(header_pattern.findall(_(""))) header_entries = dict(header_pattern.findall(_("")))
if (header_entries["Project-Id-Version"] != "gitinspector {0}".format(version)): if header_entries["Project-Id-Version"] != "gitinspector {0}".format(version):
print("WARNING: The translation for your system locale is not up to date with the current gitinspector " print("WARNING: The translation for your system locale is not up to date with the current gitinspector "
"version. The current maintainer of this locale is {0}.".format(header_entries["Last-Translator"]), "version. The current maintainer of this locale is {0}.".format(header_entries["Last-Translator"]),
file=sys.stderr) file=sys.stderr)

17
gitinspector/metrics.py
View File

@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with gitinspector. If not, see <http://www.gnu.org/licenses/>. # along with gitinspector. If not, see <http://www.gnu.org/licenses/>.
from __future__ import print_function
from __future__ import unicode_literals from __future__ import unicode_literals
from localization import N_
from outputable import Outputable
from changes import FileDiff from changes import FileDiff
import comment import comment
import filtering import filtering
@ -31,19 +28,19 @@ import subprocess
__metric_eloc__ = {"java": 500, "c": 500, "cpp": 500, "cs": 500, "h": 300, "hpp": 300, "php": 500, "py": 500, "glsl": 1000, __metric_eloc__ = {"java": 500, "c": 500, "cpp": 500, "cs": 500, "h": 300, "hpp": 300, "php": 500, "py": 500, "glsl": 1000,
"rb": 500, "js": 500, "sql": 1000, "xml": 1000} "rb": 500, "js": 500, "sql": 1000, "xml": 1000}
__metric_cc_tokens__ = [[["java", "js", "c", "cc", "cpp"], ["else", "for\s+\(.*\)", "if\s+\(.*\)", "case\s+\w+:", __metric_cc_tokens__ = [[["java", "js", "c", "cc", "cpp"], ["else", r"for\s+\(.*\)", r"if\s+\(.*\)", r"case\s+\w+:",
"default:", "while\s+\(.*\)"], "default:", r"while\s+\(.*\)"],
["assert", "break", "continue", "return"]], ["assert", "break", "continue", "return"]],
[["cs"], ["else", "for\s+\(.*\)", "foreach\s+\(.*\)", "goto\s+\w+:", "if\s+\(.*\)", "case\s+\w+:", [["cs"], ["else", r"for\s+\(.*\)", r"foreach\s+\(.*\)", r"goto\s+\w+:", r"if\s+\(.*\)", r"case\s+\w+:",
"default:", "while\s+\(.*\)"], "default:", r"while\s+\(.*\)"],
["assert", "break", "continue", "return"]], ["assert", "break", "continue", "return"]],
[["py"], ["^\s+elif .*:$", "^\s+else:$", "^\s+for .*:", "^\s+if .*:$", "^\s+while .*:$"], [["py"], [r"^\s+elif .*:$", r"^\s+else:$", r"^\s+for .*:", r"^\s+if .*:$", r"^\s+while .*:$"],
["^\s+assert", "break", "continue", "return"]]] [r"^\s+assert", "break", "continue", "return"]]]
METRIC_CYCLOMATIC_COMPLEXITY_THRESHOLD = 50 METRIC_CYCLOMATIC_COMPLEXITY_THRESHOLD = 50
METRIC_CYCLOMATIC_COMPLEXITY_DENSITY_THRESHOLD = 0.75 METRIC_CYCLOMATIC_COMPLEXITY_DENSITY_THRESHOLD = 0.75
class MetricsLogic: class MetricsLogic(object):
def __init__(self): def __init__(self):
self.eloc = {} self.eloc = {}
self.cyclomatic_complexity = {} self.cyclomatic_complexity = {}

10
gitinspector/responsibilities.py
View File

@ -21,21 +21,17 @@ from __future__ import print_function
from __future__ import unicode_literals from __future__ import unicode_literals
import blame import blame
import changes import changes
import format
import gravatar
import terminal
import textwrap
class ResponsibiltyEntry: class ResponsibiltyEntry(object):
blames = {} blames = {}
class Responsibilities: class Responsibilities(object):
@staticmethod @staticmethod
def get(hard, useweeks, author_name): def get(hard, useweeks, author_name):
author_blames = {} author_blames = {}
for i in blame.get(hard, useweeks, changes.get(hard)).blames.items(): for i in blame.get(hard, useweeks, changes.get(hard)).blames.items():
if (author_name == i[0][0]): if author_name == i[0][0]:
total_rows = i[1].rows - i[1].comments total_rows = i[1].rows - i[1].comments
if total_rows > 0: if total_rows > 0:
author_blames[i[0][1]] = total_rows author_blames[i[0][1]] = total_rows

4
gitinspector/terminal.py
View File

@ -24,8 +24,8 @@ import platform
import sys import sys
import unicodedata import unicodedata
__bold__ = "\033[1m" __bold__ = "\033[1m"
__normal__ = "\033[0;0m" __normal__ = "\033[0;0m"
DEFAULT_TERMINAL_SIZE = (80, 25) DEFAULT_TERMINAL_SIZE = (80, 25)

7
gitinspector/timeline.py
View File

@ -17,15 +17,10 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with gitinspector. If not, see <http://www.gnu.org/licenses/>. # along with gitinspector. If not, see <http://www.gnu.org/licenses/>.
from __future__ import print_function
from __future__ import unicode_literals from __future__ import unicode_literals
import datetime import datetime
import format
import gravatar
import terminal
import textwrap
class TimelineData: class TimelineData(object):
def __init__(self, changes, useweeks): def __init__(self, changes, useweeks):
authordateinfo_list = sorted(changes.get_authordateinfo_list().items()) authordateinfo_list = sorted(changes.get_authordateinfo_list().items())
self.changes = changes self.changes = changes