only attempt to remove credentals from HTTP(S) URLs

This commit is contained in:
Sunshine 2020-06-01 05:28:02 -04:00
parent ed82b96152
commit 4e31d0433e
No known key found for this signature in database
GPG key ID: B80CA68703CD8AB1

View file

@ -160,9 +160,12 @@ fn main() {
// Safe to unwrap (we just put this through an HTTP request)
let mut clean_url = Url::parse(&base_url).unwrap();
clean_url.set_fragment(None);
// Don't include credentials
clean_url.set_username("").unwrap();
clean_url.set_password(None).unwrap();
// Prevent credentials from getting into metadata
if is_http_url(&base_url) {
// Only HTTP(S) URLs may feature credentials
clean_url.set_username("").unwrap();
clean_url.set_password(None).unwrap();
}
let metadata_comment = if is_http_url(&base_url) {
format!(
"<!-- Saved from {} at {} using {} v{} -->\n",