From d889349332e945c0e1273b1f7ede353543a1632b Mon Sep 17 00:00:00 2001 From: "Kim B. Heino" Date: Wed, 7 Oct 2020 13:50:48 +0300 Subject: [PATCH] wireless: fix shellcheck warnings Shellcheck warned about "dash doesn't support x". This plugin runs only on OpenWRT and there is no dash... --- plugins/wireless | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/wireless b/plugins/wireless index f9de52f..11623f2 100644 --- a/plugins/wireless +++ b/plugins/wireless @@ -13,7 +13,7 @@ noise.label Noise" interfaces=$(iwinfo 2> /dev/null | sed '/^wlan/!d; s/ .*//g') for interface in ${interfaces} do - echo "multigraph wireless_assoc_${interface/-/_} + echo "multigraph wireless_assoc_$(clean_fieldname "${interface}") graph_title WLAN ${interface} associations graph_vlabel Clients graph_args --lower-limit 0 @@ -27,12 +27,12 @@ fetch_wireless() { for interface in ${interfaces} do echo "multigraph wireless_${interface}" - iwinfo ${interface} info | sed -r 's/unknown/0 dBm/g; /Signal.*Noise/!d; s/^.* Signal: ([-0-9]+) dBm Noise: ([-0-9]+) dBm/signal.value \1\nnoise.value \2/' + iwinfo "${interface}" info | sed -r 's/unknown/0 dBm/g; /Signal.*Noise/!d; s/^.* Signal: ([-0-9]+) dBm Noise: ([-0-9]+) dBm/signal.value \1\nnoise.value \2/' done interfaces=$(iwinfo 2> /dev/null | sed '/^wlan/!d; s/ .*//g') for interface in ${interfaces} do - echo "multigraph wireless_assoc_${interface/-/_}" - echo "clients.value $(iwinfo ${interface} assoc | grep -c SNR)" + echo "multigraph wireless_assoc_$(clean_fieldname "${interface}")" + echo "clients.value $(iwinfo "${interface}" assoc | grep -c SNR)" done }