Commit Graph

47 Commits

Author SHA1 Message Date
Daniel Alder c2b8d7315d Fix previous change. The key for config and values was the mountpoint
I accidently changed this to dev. This also works but breaks existing history
2023-12-14 13:26:47 +01:00
Daniel Alder f55b83fdbd Improve df
Before, there were 1+n calls of df where n is the number of output values. I introduced some script magic to use the values from the
first call. Motivation was, there was a very complex sed call which failed to process some of my df output lines. The new code is much
safer.

Actually, the original problem obviously was that the sed regex didn't cover capital letters which I had in my mountpoints.
2023-12-13 14:58:34 +01:00
Lars Kruse a2f1745477 plugin ntpdate: tolerate multiple NTP servers (e.g. in a pool)
Previously multiple "server" lines were consumed, but the output of the
awk filter lacked the line ending.  Thus the last numeric value of the
previous "server" line was concatenated with the first numeric value of
the following "server" line.  Thus multiple dots occurred in a single
numeric value and parsing just failed.

Thanks, glyndon!

Closes: #16
2022-05-04 14:55:41 +02:00
Kim B. Heino 74927fc6e7
ntpdate: fix typo on graph title 2021-08-22 19:37:40 +03:00
Kim B. Heino c0625af54c plugins: don't draw LINE2 where it's not needed 2020-10-18 20:27:05 +03:00
Kim B. Heino b2ca6a4b8a irqstats: rework previous commit to make shellcheck happy
Tested on dash/bash/busybox.
2020-10-09 15:40:46 +03:00
Kim B. Heino 4c53449fa3 irqstats: fix iqrstats on Raspberry Pi (partial revert for 5190244c)
Raspberry Pi has line "FIQ:              usb_fiq" in /proc/interrupts.
"VALUE=$((VALUE + VAL))" results "Illegal number" in dash (Raspberry Pi)
"VALUE=$((VALUE + $VAL))" works in dash, bash and busybox (OpenWrt).
2020-10-09 15:40:46 +03:00
Kim B. Heino 111bd0ebb3 ntpdate: add "graph_category time" to config 2020-10-08 16:14:17 +02:00
Lars Kruse 00cfedfd92
Merge pull request #7 from kimheino/wireless
wireless: add new plugin to get info about OpenWRT's APs
2020-10-08 13:28:46 +02:00
Kim B. Heino 1f6d07e52a wireless: cleanup interfaces-variable usage 2020-10-08 07:31:36 +03:00
Kim B. Heino 5206847aa1
df: fix "config" vs "fetch" mismatches (#9)
Two fixes:
1) Use same regexp to skip df partitions in "config" and "fetch".
2) Use same function (was two different sed) to cleanup partition name.

This fixes bug #5.
2020-10-07 19:11:11 +02:00
Kim B. Heino e6f5722a04 plugins/if: include "Interface" to graph_title for better grouping
Nowadays network interfaces have names like docker0, team0, ip_vti0, eno,
wlp61s0 and so on. Including word "Interface" in beginning of
graph_title groups these graphs together in web interface, not randomly
before/after other network-graphs (ipconntrack, firewall, ...).

See commit 70711831c44 in munin repository for similar change.
2020-10-07 18:41:47 +02:00
Kim B. Heino d889349332 wireless: fix shellcheck warnings
Shellcheck warned about "dash doesn't support x". This plugin runs
only on OpenWRT and there is no dash...
2020-10-07 13:50:48 +03:00
Kim B. Heino 4bc2b62610 wireless: add new plugin to get info about OpenWRT's APs
Following info is returned, per AP:
- Signal strength (dBm)
- Number of associated clients
2020-10-07 13:20:00 +03:00
Lars Kruse 8046268893 if_: handle "Unknown" emitted by ethtool
Previously error messages were emitted due to this non-numeric value.

Closes: #3
2020-08-22 20:28:09 +02:00
B. van Berkum aad298f892 Fixed category for uptime graph. 2020-02-12 04:38:07 +01:00
Lars Kruse e3103bdb6e Plugin df: ignore read-only and virtual filesystem types
The set of filesystems is based on the list of excluded filesystems in
munin's "df" plugin for Linux.
2020-02-08 23:39:44 +01:00
Lars Kruse 44d1c8dc3a Plugin if_: do not expose errors from ethtool
ethtool prints the error message "Cannot get device settings: No such
device" for VLAN devices.  This error message should not be exposed via
the munin protocol.
2020-02-08 23:39:44 +01:00
Lars Kruse 6b09d74c9a Remove tabs from plugins 2020-02-08 23:39:44 +01:00
Lars Kruse b5d8f7931b Plugin if_ and if_err_: use explicit variable for interface name 2020-02-08 23:39:44 +01:00
Lars Kruse 60b16f4121 Plugin netstat: adjust filter to newer netstat version
Newer versions of netstat use "active connection openings" instead of
"active connections".
2020-02-08 23:39:44 +01:00
Lars Kruse 974b07a1af Remove unnecessary "cat" operations 2020-02-08 23:39:44 +01:00
Lars Kruse 0600bbf113 Simplify grep-based conditionals
The "-q" argument avoids the requirement for output redirections.
2020-02-08 23:39:44 +01:00
Lars Kruse 94a695860d Simplify checks for empty or non-empty strings 2020-02-08 23:39:44 +01:00
Lars Kruse 5190244c92 Simplify arithemtic shell expressions
Variable names within arithmetic expressions are evaluated even without
the '$' prefix.
2020-02-08 23:39:44 +01:00
Lars Kruse dc242d3631 Plugin cpu: fix handling of more than ten CPUs
Previously only CPU entries with a single digit (0..9) were parsed.
The improved regular expression simplifies the calculation of the CPU
count, since the combined entry ("cpu" without digits) is skipped.
2020-02-08 23:39:44 +01:00
Lars Kruse 14251d6791 Add missing quoting 2020-02-08 23:39:44 +01:00
Lars Kruse 5de3df252e Plugin swap: fix evaluation of swap usage
The variable name was misspelled.
2020-02-08 23:39:44 +01:00
Lars Kruse d1da0df1b2 Plugin memory: fix evaluation of "inactive laundry"
The variable name was misspelled.
2020-02-08 23:39:44 +01:00
Lars Kruse 631e86156e Fix spelling issues
reported by "codespell"
2020-02-06 07:29:11 +01:00
Lars Kruse b0e991d4d4 whitespace cleanup 2020-02-06 07:29:11 +01:00
Lars Kruse ab2347f2ac swap: return "U" in case of missing swap
The swap plugin should return "U" if no value was found.

Source: patch "310-fix-swap-output" from Opennet Firmware
2019-07-19 06:10:34 +02:00
Lars Kruse 56bf90a6f8 muninlite: fix irqstats plugin
The config() function of irqstats seems to contain a superfluous
semicolon, causing munin to choke on this plugin. This simple patch
fixes exactly that.

Source: patch "240-fix-irqstats" from OpenWrt
Author: Jorik Jonker
2019-07-19 06:03:51 +02:00
Lars Kruse 7b4f376daf Fix fetching data for interfaces with a dash in the name
munin-node passes the original interface name (as extracted from
/proc/net/dev) to if_* and if_err_*. Thus replacing dash with underscore
results in interfaces not being found anymore.

Source: patch "220-modify-ifname-parser" from OpenWrt
Author: Martin Blumenstingl
2019-07-19 06:01:08 +02:00
Lars Kruse 44628e78cc uptime should report days, not seconds
Source: https://sourceforge.net/p/muninlite/patches/8/
Author: Craig Gallek

See patch "110-fix-uptime-days" in OpenWrt.
2019-07-19 05:54:53 +02:00
Lars Kruse 3e0ecfe678 Fix error messages on server due to missing ethtool on node
Source: patch "100-fix-no-ethtool" from OpenWrt
Author: cshore
2019-07-19 05:49:51 +02:00
Lars Kruse d9b1b1ad3f Enable the df plugin again and fix parsing disk usage
Source: patch "001-fix_disks" from OpenWrt
Author: Martin Blumenstingl
2019-07-19 05:45:48 +02:00
runesk 0e1e1b6bbc Arrays is a bashismn
git-svn-id: svn://svn.code.sf.net/p/muninlite/code/muninlite@31 35caa317-6b62-4e8a-81c0-b04f0c356266
2011-01-27 09:58:58 +00:00
runesk fc1c90b1a2 Keith Taylor submitted a patch to support older kernels ID: 2716990
git-svn-id: svn://svn.code.sf.net/p/muninlite/code/muninlite@29 35caa317-6b62-4e8a-81c0-b04f0c356266
2011-01-14 20:52:13 +00:00
runesk 380a399a81 Build need this empty file
git-svn-id: svn://svn.code.sf.net/p/muninlite/code/muninlite@25 35caa317-6b62-4e8a-81c0-b04f0c356266
2011-01-14 20:25:53 +00:00
runesk 78f7079596 Closes 2080844
git-svn-id: svn://svn.code.sf.net/p/muninlite/code/muninlite@20 35caa317-6b62-4e8a-81c0-b04f0c356266
2009-03-17 12:35:31 +00:00
runesk a18de9ac24 Closes 2078765
git-svn-id: svn://svn.code.sf.net/p/muninlite/code/muninlite@19 35caa317-6b62-4e8a-81c0-b04f0c356266
2009-03-17 12:17:51 +00:00
runesk 61be8d19e2 BUG: Line break
git-svn-id: svn://svn.code.sf.net/p/muninlite/code/muninlite@17 35caa317-6b62-4e8a-81c0-b04f0c356266
2007-11-30 11:24:07 +00:00
runesk 6eb9e91c1f 1.0.1
git-svn-id: svn://svn.code.sf.net/p/muninlite/code/muninlite@16 35caa317-6b62-4e8a-81c0-b04f0c356266
2007-11-30 10:43:07 +00:00
runesk 84fd994485 Nicer pipe (hint from janl)
git-svn-id: svn://svn.code.sf.net/p/muninlite/code/muninlite@15 35caa317-6b62-4e8a-81c0-b04f0c356266
2007-09-25 12:53:05 +00:00
runesk 2f8d3ffd06 SF#1736919
Changed type to DERIVE and added min values to 0. Added check for
ethtool to check if max value could be calculated


git-svn-id: svn://svn.code.sf.net/p/muninlite/code/muninlite@11 35caa317-6b62-4e8a-81c0-b04f0c356266
2007-06-15 12:07:51 +00:00
runesk 7c8bd1e394 Import
git-svn-id: svn://svn.code.sf.net/p/muninlite/code/muninlite@1 35caa317-6b62-4e8a-81c0-b04f0c356266
2007-06-11 15:45:16 +00:00