Commit Graph

136 Commits

Author SHA1 Message Date
Lars Kruse
b5d8f7931b Plugin if_ and if_err_: use explicit variable for interface name 2020-02-08 23:39:44 +01:00
Lars Kruse
60b16f4121 Plugin netstat: adjust filter to newer netstat version
Newer versions of netstat use "active connection openings" instead of
"active connections".
2020-02-08 23:39:44 +01:00
Lars Kruse
e439fd79a1 Use "read" without escaping 2020-02-08 23:39:44 +01:00
Lars Kruse
974b07a1af Remove unnecessary "cat" operations 2020-02-08 23:39:44 +01:00
Lars Kruse
0600bbf113 Simplify grep-based conditionals
The "-q" argument avoids the requirement for output redirections.
2020-02-08 23:39:44 +01:00
Lars Kruse
94a695860d Simplify checks for empty or non-empty strings 2020-02-08 23:39:44 +01:00
Lars Kruse
5190244c92 Simplify arithemtic shell expressions
Variable names within arithmetic expressions are evaluated even without
the '$' prefix.
2020-02-08 23:39:44 +01:00
Lars Kruse
dc242d3631 Plugin cpu: fix handling of more than ten CPUs
Previously only CPU entries with a single digit (0..9) were parsed.
The improved regular expression simplifies the calculation of the CPU
count, since the combined entry ("cpu" without digits) is skipped.
2020-02-08 23:39:44 +01:00
Lars Kruse
14251d6791 Add missing quoting 2020-02-08 23:39:44 +01:00
Lars Kruse
c2108276eb Improve parsing of commands and plugin names
Previously special characters for regular expressions (e.g. ".") could
work around the name check (without being able to cause harm).
2020-02-08 23:39:44 +01:00
Lars Kruse
281578664c Command "version": fix spelling of "muninlite" 2020-02-08 23:39:44 +01:00
Lars Kruse
b1230609dc Command "list": sort plugins by name and remove surrounding whitespace
Previously the plugin names were not sorted and a leading space was
emitted.
2020-02-08 23:39:44 +01:00
Lars Kruse
02b2eb861e Plugin directory: use "find" instead of "ls"
Relying on shell globbing is discouraged.
2020-02-08 23:39:44 +01:00
Lars Kruse
5de3df252e Plugin swap: fix evaluation of swap usage
The variable name was misspelled.
2020-02-08 23:39:44 +01:00
Lars Kruse
d1da0df1b2 Plugin memory: fix evaluation of "inactive laundry"
The variable name was misspelled.
2020-02-08 23:39:44 +01:00
Lars Kruse
f4518e5375 Change name of executable from "munin-node" to "muninlite"
Previously MuninLite tried to create a drop-in-replacement for
munin-node by using the same name.  But MuninLite behaves differently
and may even be used in parallel to a regular munin-node setup on a host,
thus it should use a distinct name.
2020-02-08 23:39:44 +01:00
Lars Kruse
c547314f3d Makefile: add "install" target 2020-02-08 23:39:44 +01:00
Lars Kruse
33bd18f7f7 README: change to UTF8 2020-02-08 23:39:44 +01:00
Lars Kruse
0cf51803a3 Makefile: configurable set of plugins
The Makefile variable "PLUGINS" may be specified on the command line in
order to pick specific plugins:

  make PLUGINS="cpu load uptime"
2020-02-08 23:39:44 +01:00
Lars Kruse
936ac8199c Makefile: use proper indentation for assembling command 2020-02-08 23:39:42 +01:00
Lars Kruse
160a767791 Makefile: simplify script assembling 2020-02-08 23:39:15 +01:00
Lars Kruse
92eb719a8b Makefile: reduce dependencies to the set of configured plugins 2020-02-08 23:38:15 +01:00
Lars Kruse
0667b94d0f Makefile: add dependency for template input file 2020-02-08 23:38:15 +01:00
Lars Kruse
08e989b780 examples: unify whitespace 2020-02-08 23:38:15 +01:00
Lars Kruse
4e324b45a6 CI: add travis test description 2020-02-08 23:38:15 +01:00
Lars Kruse
6e921753d6 Makefile: add trivial test
For now only the basic functionality of the script is tested.
2020-02-08 23:38:15 +01:00
Lars Kruse
c7a121f8fc Makefile: add spelling check 2020-02-08 23:38:15 +01:00
Lars Kruse
806dc07f89 README: reduce less relevant details 2020-02-08 23:37:55 +01:00
Lars Kruse
490da2c8a3 README: document the installation as an executable without TCP 2020-02-08 23:37:55 +01:00
Lars Kruse
0c4e577e9a Makefile: add 'lint' target
For now most plugins contain issues according to 'shellcheck'.
2020-02-08 23:37:52 +01:00
Lars Kruse
5f1d1b03b5 Transfer remaining subversion details to git 2020-02-06 07:29:11 +01:00
Lars Kruse
a3fde3c704 Makefile: use "git archive" for generating release file 2020-02-06 07:29:11 +01:00
Lars Kruse
9748ebdcfb Makefile: add "help" target 2020-02-06 07:29:11 +01:00
Lars Kruse
631e86156e Fix spelling issues
reported by "codespell"
2020-02-06 07:29:11 +01:00
Lars Kruse
b0e991d4d4 whitespace cleanup 2020-02-06 07:29:11 +01:00
Lars Kruse
215abe08ae Makefile: mark non-file targets as "PHONY" 2020-02-06 07:29:11 +01:00
Lars Kruse
e4ef4eccea Makefile: do not create empty target file in case of errors 2020-02-06 07:29:11 +01:00
Lars Kruse
6dcd179e56 Makefile: use make variables for filenames 2019-07-23 05:19:42 +02:00
Lars Kruse
519a1c2ef9 Makefile: cleanup whitespace and comments 2019-07-23 04:42:56 +02:00
Lars Kruse
38586372d2 Format README as markdown 2019-07-19 06:25:57 +02:00
Lars Kruse
ab2347f2ac swap: return "U" in case of missing swap
The swap plugin should return "U" if no value was found.

Source: patch "310-fix-swap-output" from Opennet Firmware
2019-07-19 06:10:34 +02:00
Lars Kruse
eb5f13e9bd Makefile: fix assembly of plugins
Source: package "300-fix-munin-node-assembly" from Opennet Firmware
2019-07-19 06:08:23 +02:00
Lars Kruse
56bf90a6f8 muninlite: fix irqstats plugin
The config() function of irqstats seems to contain a superfluous
semicolon, causing munin to choke on this plugin. This simple patch
fixes exactly that.

Source: patch "240-fix-irqstats" from OpenWrt
Author: Jorik Jonker
2019-07-19 06:03:51 +02:00
Lars Kruse
b2366408f6 Fix parsing the available network interface names
Source: patch "230-fix-available-interface-parsing" from OpenWrt
Author: Martin Blumenstingl
2019-07-19 06:02:42 +02:00
Lars Kruse
7b4f376daf Fix fetching data for interfaces with a dash in the name
munin-node passes the original interface name (as extracted from
/proc/net/dev) to if_* and if_err_*. Thus replacing dash with underscore
results in interfaces not being found anymore.

Source: patch "220-modify-ifname-parser" from OpenWrt
Author: Martin Blumenstingl
2019-07-19 06:01:08 +02:00
Lars Kruse
f906a5f4da Fix error messages on server regarding recognition bridge interfaces
OpenWrt uses the naming convention "br-*" for bridge network interfaces.

Source: patch "210-add-bridge-devs" from OpenWrt
Author: cshore
2019-07-19 05:59:49 +02:00
Lars Kruse
2073b97a6c Fix error messages on server regarding recognition of tapX devices
Source: patch "200-add-tap-dev" from OpenWrt
Author: cshore
2019-07-19 05:56:35 +02:00
Lars Kruse
44628e78cc uptime should report days, not seconds
Source: https://sourceforge.net/p/muninlite/patches/8/
Author: Craig Gallek

See patch "110-fix-uptime-days" in OpenWrt.
2019-07-19 05:54:53 +02:00
Lars Kruse
3e0ecfe678 Fix error messages on server due to missing ethtool on node
Source: patch "100-fix-no-ethtool" from OpenWrt
Author: cshore
2019-07-19 05:49:51 +02:00
Lars Kruse
d9b1b1ad3f Enable the df plugin again and fix parsing disk usage
Source: patch "001-fix_disks" from OpenWrt
Author: Martin Blumenstingl
2019-07-19 05:45:48 +02:00