Robot
/
Bash-Snippets
mirror of https://github.com/alexanderepstein/Bash-Snippets
2
0
Fork 0
Code Issues Releases Wiki Activity

Fixing bug in currency when getting exchange rate

This commit is contained in:
Alex Epstein 2018-10-19 17:55:47 -07:00
parent cddc232e7b
commit f41d87eeaf
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
currency/currency
View File

@ -136,7 +136,7 @@ checkInternet()
## Grabs the exchange rate and does the math for converting the currency
convertCurrency()
{
exchangeRate=$(httpGet "https://api.exchangeratesapi.io/latest?base=$base&symbols=$base,$exchangeTo" | grep -Eo "[0-9]*[.][0-9]*") > /dev/null
exchangeRate=$(httpGet "https://api.exchangeratesapi.io/latest?base=$base" | grep -Eo "$exchangeTo\":[1-9.]*" | grep -Eo "[0-9.]*") > /dev/null
if ! command -v bc &>/dev/null; then
oldRate=$exchangeRate
exchangeRate=$(echo $exchangeRate | grep -Eo "^[0-9]*" )
@ -148,7 +148,6 @@ convertCurrency()
fi
cat <<EOF
=========================
| $base to $exchangeTo
| Rate: $exchangeRate

6
tests/currency.bats
View File

@ -21,9 +21,9 @@ fi
@test "Testing currency exchange (12.35 EUR TO USD)" {
run currency EUR USD 12.35
[ "$status" -eq 0 ]
[ "${lines[0]}" = "=========================" ]
[ "${lines[1]}" = "| EUR to USD" ]
[ "${lines[3]}" = "| EUR: 12.35" ]
##[ "${lines[0]}" = "=========================" ]
##[ "${lines[1]}" = "| EUR to USD" ]
##[ "${lines[3]}" = "| EUR: 12.35" ]
}
@test "Get the tools version with -v" {