From 26ac1795484f1a8242c180919da95d6cf841da7c Mon Sep 17 00:00:00 2001 From: cyqsimon <28627918+cyqsimon@users.noreply.github.com> Date: Mon, 26 Feb 2024 11:31:30 +0800 Subject: [PATCH] Add note on thread synchronization --- src/syntax_mapping.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/syntax_mapping.rs b/src/syntax_mapping.rs index 7c96c513..a149f9bb 100644 --- a/src/syntax_mapping.rs +++ b/src/syntax_mapping.rs @@ -89,6 +89,11 @@ impl<'a> SyntaxMapping<'a> { Lazy::force(matcher); } }); + // Note that this thread is not joined upon completion because there's + // no shared resources that need synchronization to be safely dropped. + // If we later add code into this thread that requires interesting + // resources (e.g. IO), it would be a good idea to store the handle + // and join it on drop. } pub fn insert(&mut self, from: &str, to: MappingTarget<'a>) -> Result<()> {