From cdcf8bc92978c826d9c1768b547df3b7484003f2 Mon Sep 17 00:00:00 2001 From: crestfalln Date: Fri, 29 Sep 2023 09:07:27 +0530 Subject: [PATCH] fixed bug where updated disks stats overrided disk io data --- src/btop_shared.hpp | 1 - src/linux/btop_collect.cpp | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/btop_shared.hpp b/src/btop_shared.hpp index 6f0dee5..ecf97f2 100644 --- a/src/btop_shared.hpp +++ b/src/btop_shared.hpp @@ -147,7 +147,6 @@ namespace Mem { int64_t free{}; // defaults to 0 int used_percent{}; // defaults to 0 int free_percent{}; // defaults to 0 - bool is_ready = false; array old_io = {0, 0, 0}; deque io_read = {}; diff --git a/src/linux/btop_collect.cpp b/src/linux/btop_collect.cpp index 1d449f5..b5b1cea 100644 --- a/src/linux/btop_collect.cpp +++ b/src/linux/btop_collect.cpp @@ -1111,7 +1111,6 @@ namespace Mem { disk.used = updated_stats.used; disk.used_percent = updated_stats.used_percent; disk.free_percent = updated_stats.free_percent; - disk.is_ready = true; } disks_stats_promises[mountpoint] = async(std::launch::async, [mountpoint, &free_priv]() -> pair { struct statvfs vfs; @@ -1156,7 +1155,6 @@ namespace Mem { int64_t sectors_read, sectors_write, io_ticks, io_ticks_temp; disk_ios = 0; for (auto& [ignored, disk] : disks) { - if(!disk.is_ready) continue; if (disk.stat.empty() or access(disk.stat.c_str(), R_OK) != 0) continue; if (disk.fstype == "zfs" && zfs_hide_datasets && zfs_collect_pool_total_stats(disk)) { disk_ios++;