Robot/btop
1
0
Fork 0
mirror of https://github.com/aristocratos/btop.git synced 2024-09-21 02:41:31 +02:00
Code Issues Packages Projects Releases Wiki Activity
872 Commits 4 Branches 47 Tags 10 MiB
b598f02468
Commit Graph

872 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mitchell Dorrell
3c6929b025 Fix integer overflows in btop_collect.cpp 
Correct data types in calls to std::accumulate(). The "bandwidth" deques
have type "long long", so the initial value of the accumulator (0) must
also be "long long" (i.e., "0ll") to prevent integer overflows. Also,
since since the bandwidth deques are (signed) "long long", the avg_speed
should presumably be a signed "long long" instead of an unsigned
"uint64_t". The previous behavior was for large bandwidth values to
overflow the accumulator, resulting in a negative total, which then was
cast to be a huge "uint64_t" value. As a consequence, the network graph
autoscaling was broken for large bandwidths.
 2023-05-26 01:26:21 -04:00
zackiloco
dec9fa1663 Enable Clang as a compiler. 
Clang 16.0.0 or later can now be used to compile btop. Simply call
`CXX=clang++` make.

If the CXX variable contains an incompatible Clang version try to
fallback to GCC.
 2023-05-25 23:00:07 +02:00
zackiloco
a5e4969d7e Remove pthread_exit(). 
Returning from the thread this way prevents local variables to be
destructed correctly since pthread_exit is marked noreturn.

This fixes a segmentation fault with glibc and llvm-libunwind on exit.
 2023-05-25 23:00:07 +02:00
zackiloco
a2fa9da073 Replace statvfs64 with statvfs and define _FILE_OFFSET_BITS=64. 
On my musl system statvfs64 is not exposed by default. The musl FAQ
recommends against using type64_t types, see:
https://wiki.musl-libc.org/faq.html#Q:-Do-I-need-to-define-%3Ccode%3E_LARGEFILE64_SOURCE%3C/code%3E-to-get-64bit-%3Ccode%3Eoff_t%3C/code%3E?.

Defining `_FILE_OFFSET_BITS=64` and using type_t lets type_t use the 64
bit interface, see:
https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html#index-_005fFILE_005fOFFSET_005fBITS.
 2023-05-25 23:00:07 +02:00
zackiloco
7dac8505c4 Include <codecvt> required by Clang. 2023-05-25 23:00:07 +02:00
zackiloco
34ae6d96d5 Move #include to top level and exclude Clang from compiler version 
check.

Clang cannot handle <semaphore> being included in a namespace, which is
also unadvised see:
https://softwareengineering.stackexchange.com/a/335261.

Using the fallback <semaphore.h> is only meant for GCC 10, but Clang
defines `__GNUC__ = 4` so exclude Clang.
 2023-05-25 23:00:07 +02:00
zackiloco
922b6475ae Insert std:: for warning unqualified call to std::move. 2023-05-25 23:00:07 +02:00
Jakob P. Liljenberg
808b8c1824
Merge pull request #544 from nobounce/include-by-isystem 
Include 3rd party headers with isystem to silence warnings.
 2023-05-25 19:19:38 +02:00
Jakob P. Liljenberg
4e30a976fc
Merge pull request #540 from cpalv/load_average 
update cpu load average display
 2023-05-25 16:42:43 +02:00
zackiloco
c996f50751 Include 3rd party headers with isystem to silence warnings. 2023-05-25 13:53:18 +02:00
Jakob P. Liljenberg
a1a0e4ce35
Merge pull request #525 from gwena/main 
Fix link to the themes folder
 2023-05-25 12:43:19 +02:00
cpalv
1039bd5b5d amend! update cpu load average display 
update cpu load average display

applied suggested changes
 2023-05-24 19:51:43 -05:00
cpalv
5d2f7420c3 update cpu load average display 2023-05-23 19:06:50 -05:00
Jakob P. Liljenberg
468993817a
Merge pull request #537 from Syndelis/chore/fmt-submodule 
Use `fmt` as a git submodule
 2023-05-23 17:32:58 +02:00
Brenno Lemos
1567a791a8 chore: remove spaces before language in code blocks 2023-05-23 10:28:49 -03:00
Brenno Lemos
dabb7dbd52 chore: update readme to include --recursive 2023-05-23 10:25:26 -03:00
Brenno Lemos
f0ef3c4ca4 chore: adjust worflows to recursively clone the repository 2023-05-23 10:14:32 -03:00
Brenno Lemos
816c4e43fd feat: prefer fmt submodule over copy-and-paste headers 2023-05-23 10:10:36 -03:00
romner-set
842c761a73 Fix crash when all GPU panels are open but the CPU panel is closed 2023-05-22 09:46:20 +02:00
romner
8c96bd51e9 Handle GPUs which cannot report certain stats in GPU panel 2023-05-21 20:34:47 +02:00
romner
414d7eb94c Handle GPUs which cannot report certain stats in btop_collect.cpp and CPU panel 2023-05-21 18:02:50 +02:00
aristocratos
005de97e6d Add missing fmt prefixes 2023-05-21 13:58:11 +02:00
aristocratos
1fee2bc08b Add DebugTimer class and change some Logger::error calls to Logger::debug 2023-05-21 13:52:19 +02:00
aristocratos
b0fc63537b println -> fmt::println 2023-05-21 12:26:48 +02:00
aristocratos
fbc349da2a Readd using namespace fmt 2023-05-21 12:11:29 +02:00
aristocratos
bd688e24bf Add fmt prefix for fmtlib 2023-05-21 11:58:52 +02:00
Jakob P. Liljenberg
d64f9939e6
Merge pull request #536 from stevenxxiu/fix/ambiguous-format-call 
fix: prefix with `fmt::` to fix ambiguous call to `format()`, that also refers to `/usr/include/c++/13.1.1/format`
 2023-05-21 11:54:37 +02:00
Steven Xu
7ca1cc533a fix: prefix with fmt:: to fix ambiguous call to format(), that also refers to /usr/include/c++/13.1.1/format 2023-05-21 19:33:44 +10:00
aristocratos
09c075e06c Debug times thousand separator 2023-05-21 01:11:35 +02:00
aristocratos
2e68c0b916 Fixed key > gpu_names check 2023-05-20 17:27:20 +02:00
aristocratos
04ed16a9f6 Merged changes from main 2023-05-20 17:15:45 +02:00
Jakob P. Liljenberg
bab441e9ea
Merge pull request #534 from aristocratos/fmtlib 
Add fmtlib for string formatting (WIP)
 2023-05-20 16:52:07 +02:00
aristocratos
e11d64e8d7 Debug times box changes 2023-05-20 15:20:27 +02:00
aristocratos
21b85f8913 btop.cpp -> fmt 2023-05-20 14:52:50 +02:00
aristocratos
8c710a2b68 Makefile auto detection and initial logic for excluding gpu code when libs are missing 2023-05-20 01:41:04 +02:00
aristocratos
8bae1ec092 Fixed debug timer for gpu 2023-05-20 00:13:00 +02:00
romner-set
01acfd603e Bind GPU panel to 5,6,7,8,9,0 and fully implement multi-GPU support 2023-05-19 16:42:32 +02:00
romner
22a463976d Add GPU info to CPU panel 2023-05-18 16:07:05 +02:00
romner-set
c352bf2613 Add ROCm SMI backend for AMD GPU support 2023-05-15 19:42:55 +02:00
romner-set
917d568a77 Add multi-GPU support for NVML data collection 2023-05-15 13:58:54 +02:00
romner
2d27f2ff61 Fix crash when no nvidia GPU is detected 2023-05-14 17:40:50 +02:00
romner
0e0025a2c3 Update makefile text, fix typo and adhere to contibuting guidelines 2023-05-14 17:31:39 +02:00
romner
bcffcdf19f Make GPU window's size dynamic and integrate it with the rest of btop 2023-05-14 16:53:06 +02:00
romner
95b3228308 Improve GPU side panel 2023-05-13 19:41:51 +02:00
romner
adcdc583b0 Add GPU side panel 2023-05-13 00:27:23 +02:00
romner
d522a91ef4 Add rudimentary, fullscreen single-GPU NVML utilization graph 2023-05-12 19:34:47 +02:00
Gwenael Ropert
d30c23178a Fix link to themes folder 2023-05-11 16:09:06 +02:00
Jakob P. Liljenberg
872eb3eebd
Merge pull request #506 from stwnt/LLVM 
Silence "warning: unqualified call to 'std::move'" in clang.
 2023-03-18 00:03:36 +01:00
Jakob P. Liljenberg
b84cfdc268
Merge pull request #504 from iambeingtracked/patch-1 
Update everforest-dark-hard.theme
 2023-03-18 00:02:49 +01:00
Steffen
053bacef1d Silence "warning: unqualified call to 'std::move'" in clang. 2023-03-07 13:16:04 +01:00