From 33e95e6ff9d9e634dfba2fd200b5777bab1ff9da Mon Sep 17 00:00:00 2001 From: Lars Kruse Date: Wed, 1 Aug 2018 23:56:56 +0200 Subject: [PATCH] Review and unify category assignments of plugins --- plugins/chat/tinychat_users_ | 2 +- plugins/courier/courier_log | 2 +- .../currency/zcash/zcash_flypool_hashrate_ | 2 +- plugins/gpu/amd_gpu_ | 4 +-- plugins/harddisks/powered_up_ | 2 +- plugins/http/mongrel_memory | 2 +- plugins/http/mongrel_process_memory | 2 +- plugins/jmx/examples/java/java_cpu.conf | 2 +- .../examples/java/java_process_memory.conf | 2 +- plugins/jmx/examples/java/java_threads.conf | 2 +- .../examples/tomcat/catalina_requests.conf | 2 +- .../jmx/examples/tomcat/catalina_threads.conf | 2 +- .../jmx/examples/tomcat/catalina_times.conf | 3 +- .../jmx/examples/tomcat/catalina_traffic.conf | 2 +- plugins/jmx/readme.txt | 2 +- plugins/libvirt/kvm_cpu | 2 +- plugins/libvirt/kvm_io | 2 +- plugins/libvirt/kvm_mem | 2 +- plugins/libvirt/libvirt | 32 +++++++++---------- plugins/libvirt/munin-libvirtpy | 2 +- plugins/moinmoin/moinoin_pages | 2 +- plugins/network/quagga_routes | 2 +- plugins/network/zenus_ | 2 +- plugins/omreport/omreport_fan_speed | 2 +- plugins/omreport/omreport_pwrmon_current | 2 +- plugins/omreport/omreport_pwrmon_power | 2 +- plugins/omreport/omreport_storage_temp | 2 +- plugins/omreport/omreport_temp | 2 +- plugins/other/earthquakes | 2 +- plugins/other/foldingathome_activecpu | 2 +- plugins/other/radwho_cnt | 2 +- plugins/punbb/punbb_users | 2 +- plugins/qmail/qmailsend | 2 +- plugins/qmail/qmailsend_plesk | 2 +- plugins/qmail/qremote | 2 +- plugins/reddit_karma/reddit_karma_ | 2 +- plugins/router/tg585v7__ | 20 ++++++------ plugins/sickbeard/sickbeard_episodes | 2 +- plugins/sickbeard/sickbeard_shows | 2 +- plugins/snmp/snmp__brocade_ifs | 4 +-- plugins/spotweb/spotweb_average | 2 +- plugins/spotweb/spotweb_cat_average | 2 +- plugins/spotweb/spotweb_cat_total | 2 +- plugins/spotweb/spotweb_catsize_average | 2 +- plugins/spotweb/spotweb_total | 2 +- plugins/squid/squid | 22 ++++++------- plugins/squid/squid_efficiency | 2 +- plugins/squid/squid_times | 2 +- plugins/virtualbox/virtualbox_cpu_kernel | 2 +- plugins/virtualbox/virtualbox_cpu_user | 2 +- plugins/virtualbox/virtualbox_ram_usage | 2 +- plugins/voip/zapchans | 2 +- plugins/xen/xen | 2 +- plugins/xen/xen-cpu | 2 +- plugins/xen/xen-multi | 10 +++--- plugins/xen/xen_cpu_v2 | 2 +- plugins/xen/xen_memory | 2 +- plugins/xen/xen_traffic_ | 2 +- plugins/xen/xen_vbd | 2 +- 59 files changed, 99 insertions(+), 100 deletions(-) diff --git a/plugins/chat/tinychat_users_ b/plugins/chat/tinychat_users_ index d366b372..b9c8d258 100755 --- a/plugins/chat/tinychat_users_ +++ b/plugins/chat/tinychat_users_ @@ -36,7 +36,7 @@ echo "graph_title Tinychat Users for $room" echo 'graph_args --base 1000' echo 'graph_scale no' echo 'graph_vlabel Room Users' - echo 'graph_category Chat' + echo 'graph_category chat' echo 'total_count.label Room Users' echo 'total_count.draw AREA' echo 'broadcaster_count.draw STACK' diff --git a/plugins/courier/courier_log b/plugins/courier/courier_log index f1796d4e..62231f58 100755 --- a/plugins/courier/courier_log +++ b/plugins/courier/courier_log @@ -49,7 +49,7 @@ if [ "$1" = "config" ]; then graph_title Courier log ($type) graph_args --base 1000 -l 0 graph_vlabel events per second -graph_category Mail +graph_category mail EOT echo "$CATEGORIES" | while read field label match; do echo "${field}.label $(echo "$label" | tr "_" " ")" diff --git a/plugins/currency/zcash/zcash_flypool_hashrate_ b/plugins/currency/zcash/zcash_flypool_hashrate_ index 8db6effc..a93c0acc 100755 --- a/plugins/currency/zcash/zcash_flypool_hashrate_ +++ b/plugins/currency/zcash/zcash_flypool_hashrate_ @@ -63,7 +63,7 @@ if command == 'config': print("graph_title Flypool {}".format(miner)) print("graph_info zcash.flypool.org Mining Pool Hashrate for {}_{}".format(zcash_address, miner)) print("graph_vlabel Flypool Hashrate") - print("graph_category other") + print("graph_category htc") print("flypool_hs_{}_{}.warning 200:".format(zcash_address, miner)) print("flypool_hs_{}_{}.critical 100:".format(zcash_address, miner)) print("flypool_hs_{}_{}.label H/s:".format(zcash_address, miner)) diff --git a/plugins/gpu/amd_gpu_ b/plugins/gpu/amd_gpu_ index 85491c8d..3bbc2ae8 100755 --- a/plugins/gpu/amd_gpu_ +++ b/plugins/gpu/amd_gpu_ @@ -138,7 +138,7 @@ if [ "$1" = "config" ]; then echo 'graph_title GPU clock' echo "graph_args -l 0 -u $maxclock" echo 'graph_vlabel MHz' - echo 'graph_category sensors' + echo 'graph_category htc' echo "graph_info Core and memory clock info for AMD GPUs" nGpusCounter=0 while [ $nGpusCounter -lt $nGpus ] @@ -170,7 +170,7 @@ if [ "$1" = "config" ]; then echo 'graph_title GPU load' echo 'graph_args -l 0 -u 100' echo 'graph_vlabel Percentage' - echo 'graph_category sensors' + echo 'graph_category htc' echo "graph_info GPU load" nGpusCounter=0 while [ $nGpusCounter -lt $nGpus ] diff --git a/plugins/harddisks/powered_up_ b/plugins/harddisks/powered_up_ index 3eddfd25..24eff467 100755 --- a/plugins/harddisks/powered_up_ +++ b/plugins/harddisks/powered_up_ @@ -12,7 +12,7 @@ case $1 in cat <{name} upload.label Uploaded diff --git a/plugins/omreport/omreport_fan_speed b/plugins/omreport/omreport_fan_speed index c8694f11..2401897d 100755 --- a/plugins/omreport/omreport_fan_speed +++ b/plugins/omreport/omreport_fan_speed @@ -92,7 +92,7 @@ else { print "graph_title OpenManage - Fan Probes\n"; print "graph_args --base 1000 -l 0\n"; print "graph_vlabel Speed in RPMs\n"; - print "graph_category Sensors\n"; + print "graph_category sensors\n"; foreach my $j (sort keys %val) { print "fan_$j.label $val{$j}{\"Probe Name\"}\n"; if ($val{$j}{"Warning Threshold"} !~ m/\[N\/A\]/i) { diff --git a/plugins/omreport/omreport_pwrmon_current b/plugins/omreport/omreport_pwrmon_current index 0734764c..b8e8a0cc 100755 --- a/plugins/omreport/omreport_pwrmon_current +++ b/plugins/omreport/omreport_pwrmon_current @@ -91,7 +91,7 @@ else { print "graph_title OpenManage - Power Monitoring - Current\n"; print "graph_args --base 1000 -l 0\n"; print "graph_vlabel Amps\n"; - print "graph_category Sensors\n"; + print "graph_category sensors\n"; foreach my $j (sort keys %val) { print "$j.label $val{$j}{label}\n"; } diff --git a/plugins/omreport/omreport_pwrmon_power b/plugins/omreport/omreport_pwrmon_power index 0d223ca2..c5c2ddbe 100755 --- a/plugins/omreport/omreport_pwrmon_power +++ b/plugins/omreport/omreport_pwrmon_power @@ -101,7 +101,7 @@ else { print "graph_title OpenManage - Power Monitoring - Power\n"; print "graph_args --base 1000 -l 0\n"; print "graph_vlabel Watts\n"; - print "graph_category Sensors\n"; + print "graph_category sensors\n"; foreach my $j (sort keys %val) { print "$j.label $val{$j}{label}\n"; if ($val{$j}{warning}) { diff --git a/plugins/omreport/omreport_storage_temp b/plugins/omreport/omreport_storage_temp index b821289d..0c8be449 100755 --- a/plugins/omreport/omreport_storage_temp +++ b/plugins/omreport/omreport_storage_temp @@ -162,7 +162,7 @@ else { print "graph_title OpenManage - Storage - Temperatures\n"; print "graph_args --base 1000 -l 0\n"; print "graph_vlabel Temp in Degrees Celsius\n"; - print "graph_category Sensors\n"; + print "graph_category sensors\n"; print "graph_info Temperature sensors within storage enclosures on the system, typically external ones managed via PERC 6/E adapters.\n"; } foreach my $c (sort keys %ctrlrs) { diff --git a/plugins/omreport/omreport_temp b/plugins/omreport/omreport_temp index ddf2c346..f7bcb3f9 100755 --- a/plugins/omreport/omreport_temp +++ b/plugins/omreport/omreport_temp @@ -92,7 +92,7 @@ else { print "graph_title OpenManage - Temperature Probes\n"; print "graph_args --base 1000 -l 0\n"; print "graph_vlabel Temperature in Celsius\n"; - print "graph_category Sensors\n"; + print "graph_category sensors\n"; foreach my $j (sort keys %val) { print "probe_$j.label $val{$j}{\"Probe Name\"}\n"; print "probe_$j.warning $val{$j}{\"Warning Threshold\"}\n"; diff --git a/plugins/other/earthquakes b/plugins/other/earthquakes index 38f9ae98..08666c57 100755 --- a/plugins/other/earthquakes +++ b/plugins/other/earthquakes @@ -57,7 +57,7 @@ if (defined $ARGV[0] and $ARGV[0] eq "config") { print "graph_title Earthquakes by region\n"; print "graph_args --base 1000\n"; - print "graph_category Other\n"; + print "graph_category other\n"; print "graph_info This graph shows earthquakes by region of magnitude 1.0 or greater.\n"; print "graph_vlabel Number of Earthquakes\n"; diff --git a/plugins/other/foldingathome_activecpu b/plugins/other/foldingathome_activecpu index c14cf82d..3162476e 100755 --- a/plugins/other/foldingathome_activecpu +++ b/plugins/other/foldingathome_activecpu @@ -21,7 +21,7 @@ if len(sys.argv) == 2 and sys.argv[1] == "autoconf": elif len(sys.argv) == 2 and sys.argv[1] == "config": print 'graph_title Active CPU in FoldingAtHome project' print 'graph_vlabel Systems' - print 'graph_category other' + print 'graph_category htc' print 'windows.label Windows' print 'ppc.label MacOS/PowerPC' diff --git a/plugins/other/radwho_cnt b/plugins/other/radwho_cnt index 0254f4fa..722398db 100755 --- a/plugins/other/radwho_cnt +++ b/plugins/other/radwho_cnt @@ -11,7 +11,7 @@ if [ "$1" = "config" ]; then echo 'graph_args --base 1000 -l 0' echo 'graph_vlabel users' echo 'graph_noscale true' - echo 'graph_category other' + echo 'graph_category auth' echo 'usercnt.label users' echo 'graph_info FreeRadius active users count.' echo 'usercnt.info FreeRadius active users count' diff --git a/plugins/punbb/punbb_users b/plugins/punbb/punbb_users index e826400a..453fc923 100755 --- a/plugins/punbb/punbb_users +++ b/plugins/punbb/punbb_users @@ -55,7 +55,7 @@ if ( defined $ARGV[0] and $ARGV[0] eq "config" ) print "graph_title Users\n"; print "graph_args --base 1000\n"; print "graph_vlabel current users\n"; - print "graph_category Forum\n"; + print "graph_category forum\n"; print "graph_total Total\n"; print "members.label Members\n"; diff --git a/plugins/qmail/qmailsend b/plugins/qmail/qmailsend index 12a44ec2..b0b750f3 100755 --- a/plugins/qmail/qmailsend +++ b/plugins/qmail/qmailsend @@ -68,7 +68,7 @@ if (exists $ARGV[0]) { print "graph_title Qmail outgoing SMTP replies\n"; print "graph_args --base 1000 -l 0 \n"; print "graph_vlabel replies/hour\n"; - print "graph_category Mail\n"; + print "graph_category mail\n"; print "graph_total Total\n" if (keys (%descriptions) > 1); print "graph_info This graph shows qmail-send transaction response codes.\n"; print "graph_order res" . join(" res", sort by_code keys %descriptions) . "\n"; diff --git a/plugins/qmail/qmailsend_plesk b/plugins/qmail/qmailsend_plesk index 22f2f7f7..2e9e767f 100755 --- a/plugins/qmail/qmailsend_plesk +++ b/plugins/qmail/qmailsend_plesk @@ -68,7 +68,7 @@ if (exists $ARGV[0]) { print "graph_title Qmail outgoing SMTP replies\n"; print "graph_args --base 1000 -l 0 \n"; print "graph_vlabel replies/hour\n"; - print "graph_category Mail\n"; + print "graph_category mail\n"; print "graph_total Total\n" if (keys (%descriptions) > 1); print "graph_info This graph shows qmail-send transaction response codes.\n"; print "graph_order res" . join(" res", sort by_code keys %descriptions) . "\n"; diff --git a/plugins/qmail/qremote b/plugins/qmail/qremote index 52746152..2abe07ce 100755 --- a/plugins/qmail/qremote +++ b/plugins/qmail/qremote @@ -19,7 +19,7 @@ if [ "$1" = "config" ]; then graph_title Qmail-remote processes graph_args --base 1000 -l 0 graph_vlabel running processes -graph_category Mail +graph_category mail remote.label remote remote.type GAUGE EOT diff --git a/plugins/reddit_karma/reddit_karma_ b/plugins/reddit_karma/reddit_karma_ index 689a283c..9ff633c7 100755 --- a/plugins/reddit_karma/reddit_karma_ +++ b/plugins/reddit_karma/reddit_karma_ @@ -49,7 +49,7 @@ if [ "$1" = "config" ]; then echo 'graph_args --base 1000' echo 'graph_scale no' echo 'graph_vlabel Link Karma' - echo 'graph_category other' + echo 'graph_category forum' echo 'comment_karma.label Comment Karma' echo 'comment_karma.draw LINE' echo 'link_karma.label Link Karma' diff --git a/plugins/router/tg585v7__ b/plugins/router/tg585v7__ index 1f5b9e10..d410e893 100755 --- a/plugins/router/tg585v7__ +++ b/plugins/router/tg585v7__ @@ -149,7 +149,7 @@ if ( defined $ARGV[0] and $ARGV[0] eq "config" ) { if ( $mode eq 'bandwidth' ) { print < 'Xen Domain CPU Usage', 'graph_args' => '--base 1000 -l 0 --upper-limit 100 --rigid', 'graph_vlabel' => 'Percent (%)', - 'graph_category' => 'Virtualization', + 'graph_category' => 'virtualization', 'graph_info' => 'Display the % of CPU Usage for each domain', ); diff --git a/plugins/xen/xen-multi b/plugins/xen/xen-multi index 233dfb5c..dafaa57a 100755 --- a/plugins/xen/xen-multi +++ b/plugins/xen/xen-multi @@ -169,7 +169,7 @@ if ($ARGV[0] eq "config") { print "graph_args --base 1000 -l 0\n"; print "graph_vlabel cpu seconds\n"; print "graph_scale no\n"; - print "graph_category Virtualization\n"; + print "graph_category virtualization\n"; print "graph_info This graph shows CPU time for each Xen domain.\n"; for $domain (@domainlist) { print "$domains{$domain}{'munindomain'}_cpu_time.label ".trim_label('pos',$domain)."\n"; @@ -186,7 +186,7 @@ if ($ARGV[0] eq "config") { print "graph_args --base 1000 -l 0 --upper-limit 100\n"; print "graph_vlabel %\n"; print "graph_scale no\n"; - print "graph_category Virtualization\n"; + print "graph_category virtualization\n"; print "graph_info This graph shows CPU utilization for each Xen domain.\n"; for $domain (@domainlist) { print "$domains{$domain}{'munindomain'}_cpu.label ".trim_label('pos',$domain)."\n"; @@ -199,7 +199,7 @@ if ($ARGV[0] eq "config") { print "graph_title Xen domains memory usage\n"; print "graph_args --base 1024 -l 0\n"; print "graph_vlabel bytes\n"; - print "graph_category Virtualization\n"; + print "graph_category virtualization\n"; print "graph_info This graph shows memory usage for each Xen domain.\n"; for $domain (@domainlist) { print "$domains{$domain}{'munindomain'}_mem.label ".trim_label('pos',$domain)."\n"; @@ -213,7 +213,7 @@ if ($ARGV[0] eq "config") { print "graph_title Xen domains network traffic\n"; print "graph_args --base 1000\n"; print "graph_vlabel bits per \${graph_period} in (-) / out (+)\n"; - print "graph_category Virtualization\n"; + print "graph_category virtualization\n"; print "graph_info This graph shows network traffic for each Xen domain.\n"; for $domain (@domainlist) { print "$domains{$domain}{'munindomain'}_netrx.label none\n"; @@ -233,7 +233,7 @@ if ($ARGV[0] eq "config") { print "graph_title Xen domains disk IOs\n"; print "graph_args --base 1000\n"; print "graph_vlabel IOs per \${graph_period} read (-) / write (+)\n"; - print "graph_category Virtualization\n"; + print "graph_category virtualization\n"; print "graph_info This graph shows disk IOs for each Xen domain.\n"; for $domain (@domainlist) { print "$domains{$domain}{'munindomain'}_vbdrd.label none\n"; diff --git a/plugins/xen/xen_cpu_v2 b/plugins/xen/xen_cpu_v2 index aa58184c..63e41248 100755 --- a/plugins/xen/xen_cpu_v2 +++ b/plugins/xen/xen_cpu_v2 @@ -72,7 +72,7 @@ if ( defined($ARGV[0]) ) 'graph_title' => 'Xen Domain CPU Usage v2', 'graph_args' => '--base 1000 -l 0 --upper-limit 100 --rigid', 'graph_vlabel' => 'Percent (%)', - 'graph_category' => 'Virtualization', + 'graph_category' => 'virtualization', 'graph_info' => 'Display the % of CPU Usage for each domain', ); diff --git a/plugins/xen/xen_memory b/plugins/xen/xen_memory index 9fdc4d7b..90fbb56b 100755 --- a/plugins/xen/xen_memory +++ b/plugins/xen/xen_memory @@ -29,7 +29,7 @@ if [ "$1" = "config" ]; then echo 'graph_args --base 1000 -l 0' echo 'graph_scale no' echo 'graph_vlabel MB' - echo 'graph_category Virtualization' + echo 'graph_category virtualization' echo 'graph_info This graph shows of many mS wall time where used by a domain' "$XM" info | while read -r name bla value; do # total_memory 2047 diff --git a/plugins/xen/xen_traffic_ b/plugins/xen/xen_traffic_ index 57e96a52..386320e9 100755 --- a/plugins/xen/xen_traffic_ +++ b/plugins/xen/xen_traffic_ @@ -33,7 +33,7 @@ if [ "$1" = "config" ]; then # shellcheck disable=SC2016 echo 'graph_vlabel bits in (-) / out (+) per ${graph_period}' echo 'graph_args --base 1024 -l 0' - echo 'graph_category Virtualization' + echo 'graph_category virtualization' echo 'out.label sent' echo 'out.type DERIVE' echo 'out.min 0' diff --git a/plugins/xen/xen_vbd b/plugins/xen/xen_vbd index da34765a..1f74c24b 100755 --- a/plugins/xen/xen_vbd +++ b/plugins/xen/xen_vbd @@ -42,7 +42,7 @@ if ( defined($ARGV[0])) 'graph_title' => 'Xen Domain I/O usage', 'graph_args' => '--base 1024 -l 0', 'graph_vlabel' => 'read (-), write (+)', - 'graph_category' => 'Virtualization', + 'graph_category' => 'virtualization', 'graph_info' => 'Display the I/O operations for each domain', );