From 6c0e154e07e1dde9286e935f017a23bc01c42126 Mon Sep 17 00:00:00 2001
From: Lars Kruse <devel@sumpfralle.de>
Date: Fri, 9 Mar 2018 05:33:37 +0100
Subject: [PATCH] tests: add "shellcheck" tests for "ksh" scripts

---
 .travis.yml |  2 +-
 t/test.t    | 20 ++++++++++++++------
 2 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 97decfbd..f9b78219 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,7 +2,7 @@
 dist: trusty
 install:
   - sudo apt-get update
-  - sudo apt-get --no-install-recommends install devscripts python python3 ruby php5-cli gawk ksh zsh pylint
+  - sudo apt-get --no-install-recommends install devscripts python python3 ruby php5-cli gawk ksh zsh pylint shellcheck
   - sudo apt-get --no-install-recommends install pkg-config libdb-dev libvirt-dev libexpat-dev
   # - Munin/Plugin.pm is in "munin-node" on precise
   - sudo apt-get --no-install-recommends install munin-node
diff --git a/t/test.t b/t/test.t
index 86b76b95..db30c126 100644
--- a/t/test.t
+++ b/t/test.t
@@ -85,12 +85,20 @@ sub process_file {
         };
     }
     elsif ( $interpreter =~ m{/bin/ksh} ) {
-        run_check(
-            {   command     => [ 'ksh', '-n', $file ],
-                description => 'ksh syntax check',
-                filename    => $filename
-            }
-        );
+        subtest $filename => sub {
+            plan tests => 2;
+            run_check(
+                {   command     => [ 'ksh', '-n', $file ],
+                    description => 'ksh syntax check',
+                    filename    => $filename
+                }
+            );
+            run_check(
+                {   command     => [ 'shellcheck', $file ],
+                    description => 'shellcheck'
+                }
+            );
+        }
     }
     elsif ( $interpreter =~ m{bash} ) {
         run_check(