Robot/contrib-munin
2
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2018-11-08 00:59:34 +01:00
Code Issues Releases Wiki Activity

Add TODO and FIXME notes on some issues

Browse Source 
TODO 1: Follow multigraph suggestion from Flameeyes to look into multigraph
plugins (http://munin-monitoring.org/wiki/MultigraphSampleOutput),
in order to reduce the amount of round trips to get the data.

TODO 2: Put warning and critical as vars in config with sensible defaults.

TODO 3: Add additional output options for nvidia-smi only available for
professional GPUs.

FIXME: Possible bug in lines 87-91 of amd_gpu_
This commit is contained in:
Nuno Fachada 2012-12-29 01:58:31 +00:00 committed by Steve Schnepp
parent 426bba4466
commit 758ca724a0
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/gpu/amd_gpu_
View File

@ -83,6 +83,7 @@ nGpusOutput=`$atiConfigExec --list-adapters`
nGpus=`echo "$nGpusOutput" | wc -l`
nGpus=$((nGpus - 2)) # Last two lines don't matter
# FIXME Possible bug in code bellow: maybe should be <= 0 instead of == 0?
if [ $nGpus -eq 0 ]; then
# Exit if no GPUs found
echo "No AMD GPUs detected. Exiting."
@ -230,6 +231,9 @@ do
: $(( nGpusCounter = $nGpusCounter + 1 ))
done
# TODO Follow multigraph suggestion from Flameeyes to look into multigraph plugins http://munin-monitoring.org/wiki/MultigraphSampleOutput, in order to reduce the amount of round trips to get the data.
# TODO Put warning and critical as vars in config with sensible defaults

6
plugins/gpu/nvidia_gpu_
View File

@ -204,5 +204,11 @@ do
: $(( nGpusCounter = $nGpusCounter + 1 ))
done
# TODO Follow multigraph suggestion from Flameeyes to look into multigraph plugins http://munin-monitoring.org/wiki/MultigraphSampleOutput, in order to reduce the amount of round trips to get the data.
# TODO Put warning and critical as vars in config with sensible defaults
# TODO Nvidia only: Add unsupported output options from nvidia-smi for those who have that option (how to test?). Test if they are supported and put them in suggest (or not) in case they are supported (or not)