From 7e3664da84441feba3d771ccf6395cc3f4b44107 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Droz?= <raphael.droz+floss@gmail.com>
Date: Fri, 8 Jan 2016 13:27:56 -0300
Subject: [PATCH] apache_average_time_last_n_requests: ability to create
 multiple instances for distincts log files

---
 .../apache_average_time_last_n_requests       | 38 ++++++++++++++++---
 1 file changed, 32 insertions(+), 6 deletions(-)
 mode change 100755 => 100644 plugins/apache/apache_average_time_last_n_requests

diff --git a/plugins/apache/apache_average_time_last_n_requests b/plugins/apache/apache_average_time_last_n_requests
old mode 100755
new mode 100644
index 04002839..f302eda4
--- a/plugins/apache/apache_average_time_last_n_requests
+++ b/plugins/apache/apache_average_time_last_n_requests
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 # Author: Nicolas Mendoza <nicolasm@opera.com> - 2008-06-18
+#	  Raphaël Droz <raphael.droz@gmail.com> - 2016-01-08
 #
 # Monitors the average time requests matching a custom regexp takes
 # For instance monitor time execution of files in http://example.com/foo/bar, 
@@ -17,15 +18,35 @@
 # Check http://httpd.apache.org/docs/2.2/mod/mod_log_config.html#formats for more info
 #
 # Configurable variables
-# 	fieldno      - Override the default field number
-#   linecount    - How many last request to consider
+#	fieldno      - Override the default field number
+#	linecount    - How many last request to consider
+# Multiples instances for specific log files could be created by suffixing a configuration group.
+# Eg: ln -s apache_average_time_last_n_requests apache_average_time_last_n_requests_vhost1
+# Then:
+# [apache_average_time_last_n_requests]
+# 	logfile_vhost1 /var/log/apache/vhost1.log
+#
 #%# family=auto
 
 use strict;
 
+$0 =~ /apache_average_time_last_n_requests_(.+)*$/;
+my $name = $1;
+
 my $LAST_N_REQUESTS = exists $ENV{'linecount'} ? $ENV{'linecount'} : 100000; # calculate based on this amount of requests
-my $TIME_FIELD_INDEX =  exists $ENV{'fieldno'} ? $ENV{'fieldno'} : -2; # second last field
-my $ACCESS_LOG_PATTERN = '/var/log/apache2/access.log.*'; # log pattern, if many it will take the last one.
+my $TIME_FIELD_INDEX = exists $ENV{'fieldno'} ? $ENV{'fieldno'} : -2; # second last field
+my $ACCESS_LOG_PATTERN;
+
+# log pattern, if globbing is used, it will take the last one.
+if (! $name) {
+    $ACCESS_LOG_PATTERN = exists $ENV{'logfile'} ? $ENV{'logfile'} : '/var/log/apache2/access.log.*';
+}
+elsif (exists $ENV{'logfile_' . $name}) {
+    $ACCESS_LOG_PATTERN = $ENV{'logfile_' . $name};
+}
+else {
+    $ACCESS_LOG_PATTERN = '/var/log/apache2/access.log.*';
+}
 
 my $config =<< "CONFIG"
 graph_title Apache average seconds last $LAST_N_REQUESTS requests
@@ -65,12 +86,12 @@ my $types = {
       my ($fields) = @_; 
       my $script; 
       ($script = $fields->[6]) =~ s/\?.*\z //mx; 
-      return $script =~ m{ \.(png|jpe?g|jpg|gif|tiff|ilbm|tga) \z }mx; 
+      return $script =~ m{ \.(png|jpe?g|gif|tiff|ilbm|tga) \z }mx; 
     },
   },
 };
 
-if (defined(@ARGV) && ($ARGV[0] eq 'config')) {
+if (@ARGV && $ARGV[0] eq 'config') {
 
   print $config;
 
@@ -88,16 +109,21 @@ chomp $config_file;
 
 my @lines = `tail -n $LAST_N_REQUESTS "$config_file"`;
 
+FOO: {
 foreach my $line (@lines) {
   foreach my $type (keys %{$types}) {
     my @fields = split /\s+/, $line;
     if ($types->{$type}->{'matches'}(\@fields)) {
+		if ($fields[$TIME_FIELD_INDEX] !~ m/^[0-9]+$/) {
+		    last FOO;
+		}
       $types->{$type}->{'sum'} += $fields[$TIME_FIELD_INDEX];
       $types->{$type}->{'lines'}++;
     }
   }
 } 
 
+}
 foreach my $type (keys %{$types}) {
   my $value = $types->{$type}->{'lines'} ? $types->{$type}->{'sum'} / $types->{$type}->{'lines'} : 'U';
   printf "%s.value %s\n", ($type, $value);