mirror of
https://github.com/munin-monitoring/contrib.git
synced 2018-11-08 00:59:34 +01:00
kvm_net: unify quoting
This commit is contained in:
parent
e87d3a6b3c
commit
7f98e21f2b
@ -19,9 +19,10 @@ import re, os, sys
|
||||
from subprocess import Popen, PIPE
|
||||
|
||||
def config(vm_names):
|
||||
''' Print the plugin's config
|
||||
""" Print the plugin's config
|
||||
|
||||
@param vm_names : a list of "cleaned" vms' name
|
||||
'''
|
||||
"""
|
||||
base_config = """graph_title KVM Network I/O
|
||||
graph_vlabel Bytes rx(-)/tx(+) per second
|
||||
graph_category Virtualization
|
||||
@ -41,21 +42,23 @@ graph_args --base 1024
|
||||
print "%s_out.draw LINE2" % vm
|
||||
|
||||
def clean_vm_name(vm_name):
|
||||
''' Replace all special chars
|
||||
""" Replace all special chars
|
||||
|
||||
@param vm_name : a vm's name
|
||||
@return cleaned vm's name
|
||||
'''
|
||||
"""
|
||||
# suffix part defined in conf
|
||||
suffix = os.getenv('vmsuffix')
|
||||
suffix = os.getenv("vmsuffix")
|
||||
if suffix:
|
||||
vm_name = re.sub(suffix,'',vm_name)
|
||||
vm_name = re.sub(suffix, "", vm_name)
|
||||
|
||||
return re.sub(r"[^a-zA-Z0-9_]", "_", vm_name)
|
||||
|
||||
def fetch(vms):
|
||||
''' Fetch values for a list of pids
|
||||
""" Fetch values for a list of pids
|
||||
|
||||
@param dictionnary {kvm_pid: cleaned vm name}
|
||||
'''
|
||||
"""
|
||||
res = {}
|
||||
for pid in vms:
|
||||
tap = get_vm_mac(pid)
|
||||
@ -71,16 +74,16 @@ def fetch(vms):
|
||||
continue
|
||||
|
||||
def detect_kvm():
|
||||
''' Check if kvm is installed
|
||||
'''
|
||||
""" Check if kvm is installed """
|
||||
kvm = Popen("which kvm", shell=True, stdout=PIPE)
|
||||
kvm.communicate()
|
||||
return not bool(kvm.returncode)
|
||||
|
||||
def find_vm_names(pids):
|
||||
'''Find and clean vm names from pids
|
||||
"""Find and clean vm names from pids
|
||||
|
||||
@return a dictionnary of {pids : cleaned vm name}
|
||||
'''
|
||||
"""
|
||||
result = {}
|
||||
for pid in pids:
|
||||
cmdline = open("/proc/%s/cmdline" % pid, "r")
|
||||
@ -88,25 +91,27 @@ def find_vm_names(pids):
|
||||
return result
|
||||
|
||||
def get_vm_mac(pid):
|
||||
'''Find and clean vm names from pids
|
||||
"""Find and clean vm names from pids
|
||||
|
||||
@return the mac address for a specified pid
|
||||
'''
|
||||
"""
|
||||
cmdline = open("/proc/%s/cmdline" % pid, "r")
|
||||
line = cmdline.readline()
|
||||
mac = re.sub(r"^.*ifname=(tap[^,]+),.*$",r"\1", line)
|
||||
return mac
|
||||
|
||||
def list_pids():
|
||||
''' Find the pid of kvm processes
|
||||
""" Find the pid of kvm processes
|
||||
|
||||
@return a list of pids from running kvm
|
||||
'''
|
||||
"""
|
||||
pid = Popen("pidof qemu-kvm qemu-system-x86_64 kvm", shell=True, stdout=PIPE)
|
||||
return pid.communicate()[0].split()
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
if len(sys.argv) > 1:
|
||||
if sys.argv[1] in ['autoconf', 'detect']:
|
||||
if sys.argv[1] in ["autoconf", "detect"]:
|
||||
if detect_kvm():
|
||||
print "yes"
|
||||
else:
|
||||
|
Loading…
Reference in New Issue
Block a user