Robot/contrib-munin
2
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2018-11-08 00:59:34 +01:00
Code Issues Releases Wiki Activity

Plugin proftpd_count: fix shellcheck issues

Browse Source
This commit is contained in:
Lars Kruse 2018-08-02 00:15:53 +02:00
parent b925a10155
commit 9c1689fbef
1 changed files with 17 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
plugins/ftp/proftpd_count
View File

@ -14,14 +14,13 @@
#%# family=auto #%# family=auto
#%# capabilities=autoconf #%# capabilities=autoconf
MAXLABEL=20
mktempfile () { mktempfile () {
mktemp -t $1 mktemp -t "$1"
} }
LOGFILE=${logfile:-/var/log/proftpd/xferlog} LOGFILE=${logfile:-/var/log/proftpd/xferlog}
LOGTAIL=${logtail:-`which logtail`} LOGTAIL=${logtail:-$(which logtail)}
STATEFILE=$MUNIN_PLUGSTATE/xferlog-count.offset STATEFILE=$MUNIN_PLUGSTATE/xferlog-count.offset
if [ "$1" = "autoconf" ]; then if [ "$1" = "autoconf" ]; then
@ -34,30 +33,28 @@ if [ "$1" = "autoconf" ]; then
fi fi
if [ "$1" = "config" ]; then if [ "$1" = "config" ]; then
echo 'graph_title FTP Server Transfers' echo 'graph_title FTP Server Transfers'
echo 'graph_args --base 1000 -l 0' echo 'graph_args --base 1000 -l 0'
echo 'graph_vlabel FTP Server Transfers' echo 'graph_vlabel FTP Server Transfers'
echo 'graph_category network' echo 'graph_category network'
echo 'ftp_get.label Files GET' echo 'ftp_get.label Files GET'
echo 'ftp_put.label Files PUT' echo 'ftp_put.label Files PUT'
exit 0 exit 0
fi fi
ftp_get=U ftp_get=U
ftp_put=U ftp_put=U
TEMP_FILE=`mktempfile munin-xferlog-count.XXXXXX` TEMP_FILE=$(mktempfile munin-xferlog-count.XXXXXX)
if [ -n "$TEMP_FILE" -a -f "$TEMP_FILE" ] if [ -n "$TEMP_FILE" ] && [ -f "$TEMP_FILE" ]; then
then "$LOGTAIL" "$LOGFILE" "$STATEFILE" | grep "[[:space:]][oi][[:space:]]" >"$TEMP_FILE"
$LOGTAIL ${LOGFILE} $STATEFILE | grep "[[:space:]][oi][[:space:]]" > ${TEMP_FILE} ftp_get=$(grep "[[:space:]]o[[:space:]]" "$TEMP_FILE" | wc -l)
ftp_get=`grep "[[:space:]]o[[:space:]]" ${TEMP_FILE} | wc -l` ftp_put=$(grep "[[:space:]]i[[:space:]]" "$TEMP_FILE" | wc -l)
ftp_put=`grep "[[:space:]]i[[:space:]]" ${TEMP_FILE} | wc -l`
/bin/rm -f $TEMP_FILE /bin/rm -f "$TEMP_FILE"
fi fi
echo "ftp_get.value ${ftp_get}" echo "ftp_get.value $ftp_get"
echo "ftp_put.value ${ftp_put}" echo "ftp_put.value $ftp_put"