From a9d8c625416c25bfba8ebfe1660c88277bcd25ba Mon Sep 17 00:00:00 2001 From: Stig Sandbeck Mathisen Date: Sun, 5 Oct 2014 00:53:39 +0200 Subject: [PATCH] add todo list for tests --- t/todo.org | 274 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 274 insertions(+) create mode 100644 t/todo.org diff --git a/t/todo.org b/t/todo.org new file mode 100644 index 00000000..ccf11d92 --- /dev/null +++ b/t/todo.org @@ -0,0 +1,274 @@ +* [0/12] tests + + 11/1006 ok + + (less 110 skipped, 883 okay) + +** TODO ok 1 # skip need better syntax check for python + + Not really OK, we need a useful syntax check for python. + + 109 of these. + +** TODO not ok 18 - plugins/zeo/zeo_monitor_: perl syntax check + + Looks like perl -T also sanitizes PERL5LIB, since this is set to + include /usr/share/perl5, where Munin::Plugin is. + +#+BEGIN_EXAMPLE +# Failed test 'plugins/zeo/zeo_monitor_: perl syntax check' +# at t/test.t line 169. +# +# Command: perl -cwT zeo_monitor_ +# +# STDOUT: +# +# +# +# STDERR: +# +# Can't locate Munin/Plugin.pm in @INC (@INC contains: /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4 /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4) at zeo_monitor_ line 67. +# BEGIN failed--compilation aborted at zeo_monitor_ line 67. +#+END_EXAMPLE + +** TODO not ok 64 - plugins/virtualization/vmware/esx_: perl syntax check + + Missing perl module. VMware::VIRuntime. Not on CPAN. + +#+BEGIN_EXAMPLE +# Failed test 'plugins/virtualization/vmware/esx_: perl syntax check' +# at t/test.t line 169. +# +# Command: perl -cw esx_ +# +# STDOUT: +# +# +# +# STDERR: +# +# Can't locate VMware/VIRuntime.pm in @INC (@INC contains: /usr/share/perl5 /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4 /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4 .) at esx_ line 118. +# BEGIN failed--compilation aborted at esx_ line 118. +# +#+END_EXAMPLE +** TODO not ok 109 - plugins/system/swapspace-info: perl syntax check + + Missing Sun::Solaris::Kstat. Not on CPAN + +#+BEGIN_EXAMPLE + +# Failed test 'plugins/system/swapspace-info: perl syntax check' +# at t/test.t line 169. +# +# Command: perl -cw swapspace-info +# +# STDOUT: +# +# +# +# STDERR: +# +# Can't locate Sun/Solaris/Kstat.pm in @INC (@INC contains: /usr/share/perl5 /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4 /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4 .) at swapspace-info line 74. +# BEGIN failed--compilation aborted at swapspace-info line 74. +# + +#+END_EXAMPLE + +** TODO not ok 110 - plugins/system/solaris-memstat: ksh syntax check + + Can't see what's wrong here. False positive? + +#+BEGIN_EXAMPLE +# Failed test 'plugins/system/solaris-memstat: ksh syntax check' +# at t/test.t line 169. +# +# Command: ksh -n solaris-memstat +# +# STDOUT: +# +# +# +# STDERR: +# +# solaris-memstat: syntax error at line 119: `if' unmatched +# +# +#+END_EXAMPLE + +** TODO not ok 112 - plugins/system/raminfo: perl syntax check + + Missing Sun::Solaris::Kstat. Not on CPAN + +#+BEGIN_EXAMPLE +# Failed test 'plugins/system/raminfo: perl syntax check' +# at t/test.t line 169. +# +# Command: perl -cw raminfo +# +# STDOUT: +# +# +# +# STDERR: +# +# Can't locate Sun/Solaris/Kstat.pm in @INC (@INC contains: /usr/share/perl5 /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4 /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4 .) at raminfo line 76. +# BEGIN failed--compilation aborted at raminfo line 76. +# +# +#+END_EXAMPLE + +** TODO not ok 191 - plugins/snmp/snmp__webthermometer + + False positive in "checkbashisms". It looks for $HOSTNAME, which is + set implicitly by bash, but explicitly by the plugin. + +#+BEGIN_EXAMPLE +# Subtest: plugins/snmp/snmp__webthermometer +1..2 +ok 1 - sh syntax check +not ok 2 - checkbashisms +# Failed test 'checkbashisms' +# at t/test.t line 169. +# +# Command: checkbashisms snmp__webthermometer +# +# STDOUT: +# +# +# +# STDERR: +# +# possible bashism in snmp__webthermometer line 44 ($HOST(TYPE|NAME)): +# HOSTNAME=`echo $HOSTNAME | sed -e 's/\.$//'` +# possible bashism in snmp__webthermometer line 47 ($HOST(TYPE|NAME)): +# echo file $FILE dir $DIR hostname $HOSTNAME linkdir $LINKDIR linkfile $LINKFILE +# +# +# Looks like you failed 1 test of 2. +#+END_EXAMPLE + +** TODO not ok 319 - plugins/rabbitmq/rabbitmq_connections + + False positive in "checkbashisms". + +#+BEGIN_EXAMPLE +# Subtest: plugins/rabbitmq/rabbitmq_connections +1..2 +ok 1 - sh syntax check +not ok 2 - checkbashisms +# Failed test 'checkbashisms' +# at t/test.t line 169. +# +# Command: checkbashisms rabbitmq_connections +# +# STDOUT: +# +# +# +# STDERR: +# +# possible bashism in rabbitmq_connections line 66 ($"foo" should be eval_gettext "foo"): +# echo "connections.value $(HOME=$HOME rabbitmqctl list_connections | grep -v "^Listing" | grep -v "done.$" | wc -l)" +# +# +# Looks like you failed 1 test of 2. +not ok 319 - plugins/rabbitmq/rabbitmq_connections +# Failed test 'plugins/rabbitmq/rabbitmq_connections' +# at t/test.t line 64. +#+END_EXAMPLE + +** TODO not ok 536 - plugins/network/multi_tcp_ping: perl syntax check + + threads… + +#+BEGIN_EXAMPLE +# Failed test 'plugins/network/multi_tcp_ping: perl syntax check' +# at t/test.t line 169. +# +# Command: perl -cw multi_tcp_ping +# +# STDOUT: +# +# +# +# STDERR: +# +# This Perl not built to support threads +# Compilation failed in require at multi_tcp_ping line 75. +# BEGIN failed--compilation aborted at multi_tcp_ping line 75. +# +# +#+END_EXAMPLE + +** TODO not ok 538 - plugins/network/ldap_connections + + False positive at 'ESTABLISHED$"'. + + Still, quite horrible shell code. + +#+BEGIN_EXAMPLE +# Subtest: plugins/network/ldap_connections +1..2 +ok 1 - sh syntax check +not ok 2 - checkbashisms +# Failed test 'checkbashisms' +# at t/test.t line 169. +# +# Command: checkbashisms ldap_connections +# +# STDOUT: +# +# +# +# STDERR: +# +# possible bashism in ldap_connections line 130 ($"foo" should be eval_gettext "foo"): +# echo "$(echo $ip | sed 's/\./_/g')_${port}.value $(grep "^tcp[46]\{0,1\}\([[:space:]]\{1,\}[[:digit:]]\{1,\}\)\{2\}[[:space:]]\{1,\}$ip[\.:]$port[[:space:]].*ESTABLISHED$" $TEMP_FILE | wc -l | sed 's/[[:space:]]*//g')" +# +# +# Looks like you failed 1 test of 2. +#+END_EXAMPLE + +** TODO not ok 572 - plugins/network/d-link-dir-655-router-statistics-plugin: ruby syntax check + + No idea + +#+BEGIN_EXAMPLE +# Failed test 'plugins/network/d-link-dir-655-router-statistics-plugin: ruby syntax check' +# at t/test.t line 169. +# +# Command: ruby -cw d-link-dir-655-router-statistics-plugin +# +# STDOUT: +# +# +# +# STDERR: +# +# /home/travis/.rvm/rubies/ruby-1.9.3-p547/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- auto_gem (LoadError) +# from /home/travis/.rvm/rubies/ruby-1.9.3-p547/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_require.rb:54:in `require' +# +# +#+END_EXAMPLE + +** TODO not ok 627 - plugins/mythtv/mythtv_status_: perl syntax check + + Missing perl module MythTV, not on CPAN. + +#+BEGIN_EXAMPLE +# Failed test 'plugins/mythtv/mythtv_status_: perl syntax check' +# at t/test.t line 169. +# +# Command: perl -cw mythtv_status_ +# +# STDOUT: +# +# +# +# STDERR: +# +# Can't locate MythTV.pm in @INC (@INC contains: /usr/share/perl5 /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4 /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4/x86_64-linux /home/travis/perl5/perlbrew/perls/5.14/lib/5.14.4 .) at mythtv_status_ line 74. +# BEGIN failed--compilation aborted at mythtv_status_ line 74. +# +# +#+END_EXAMPLE