Robot/contrib-munin
2
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2018-11-08 00:59:34 +01:00
Code Issues Releases Wiki Activity

[monit_parser] implement memory alloaction unit parsing

Browse Source 
Previously monit seems to have output memory usage in kilobytes without
a unit. Somewhen this seemed to have changed to an (optional?) suffix
(e.g. MB). Thus the new scaling may differ from the previous scaling,
which was probably broken for most users.
Additionally the units of the resulting values are clarified.
This commit is contained in:
Lars Kruse 2016-10-23 03:40:44 +02:00
parent e5fbbaea5f
commit b8f1b6c879
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/monit/monit_parser
View File

@ -78,9 +78,21 @@ def parse_processes():
except KeyError:
procs[cur_proc] = {}
continue
m = re.match(" memory kilobytes total\s+([0-9]+).*$", line)
m = re.match(" memory kilobytes total\s+([0-9.]+)(.*)$", line)
if m:
procs[cur_proc]["total_memory"] = m.group(1)
size, suffix = m.groups()
# we store memory consumption as megabytes
factor = {
"": 1024 ** -1,
"KB": 1024 ** -1,
"MB": 1024 ** 0,
"GB": 1024 ** 1,
"TB": 1024 ** 2,
}[suffix.strip().upper()]
try:
procs[cur_proc]["total_memory"] = float(size) * factor
except ValueError:
procs[cur_proc]["total_memory"] = "U"
continue
m = re.match(" cpu percent total\s+([.0-9]+)%.*$", line)
if m:
@ -100,7 +112,7 @@ if action == 'autoconf':
elif action == 'config':
procs = parse_processes()
print('graph_title Per process stats from Monit')
print('graph_vlabel numbers')
print('graph_vlabel usage of memory [MB] or cpu [%]')
print('graph_category monit')
for process in procs:
for stat in procs[process]: