From e33c35ffc3dda6e57df8d536de5b6cf042c2ea37 Mon Sep 17 00:00:00 2001 From: Stig Sandbeck Mathisen Date: Sun, 5 Oct 2014 11:52:56 +0200 Subject: [PATCH] Update TODO list [ci skip] --- t/todo.org | 85 ++++++++++++++++++++++++++++-------------------------- 1 file changed, 44 insertions(+), 41 deletions(-) diff --git a/t/todo.org b/t/todo.org index a9b3c8cf..6b58f16b 100644 --- a/t/todo.org +++ b/t/todo.org @@ -1,17 +1,39 @@ -* [0/7] tests +* munin contrib - plugin tests Summary: - Failed 6/1006 subtests - (less 110 skipped subtests: 890 okay) + Failed 7/1006 subtests -** TODO ok 1 # skip need better syntax check for python + (less 1 skipped subtest: 998 okay) - Not really OK, we need a useful syntax check for python. - 109 of these. +** [0/1] Need to investigate -** TODO not ok 110 - plugins/system/solaris-memstat: ksh syntax check +*** TODO not ok 572 - plugins/network/d-link-dir-655-router-statistics-plugin: ruby syntax check + + Need to investigate. + +#+BEGIN_EXAMPLE +# Failed test 'plugins/network/d-link-dir-655-router-statistics-plugin: ruby syntax check' +# at t/test.t line 169. +# +# Command: ruby -cw d-link-dir-655-router-statistics-plugin +# +# STDOUT: +# +# +# +# STDERR: +# +# /home/travis/.rvm/rubies/ruby-1.9.3-p547/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- auto_gem (LoadError) +# from /home/travis/.rvm/rubies/ruby-1.9.3-p547/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_require.rb:54:in `require' +# +# +#+END_EXAMPLE + +** [0/4] False positives + +*** TODO not ok 110 - plugins/system/solaris-memstat: ksh syntax check Can't see what's wrong here. False positive? @@ -32,7 +54,7 @@ # #+END_EXAMPLE -** TODO not ok 191 - plugins/snmp/snmp__webthermometer +*** TODO not ok 191 - plugins/snmp/snmp__webthermometer False positive in "checkbashisms". It looks for $HOSTNAME, which is set implicitly by bash, but explicitly by the plugin. @@ -62,7 +84,7 @@ not ok 2 - checkbashisms # Looks like you failed 1 test of 2. #+END_EXAMPLE -** TODO not ok 319 - plugins/rabbitmq/rabbitmq_connections +*** TODO not ok 319 - plugins/rabbitmq/rabbitmq_connections False positive in "checkbashisms". @@ -92,32 +114,9 @@ not ok 319 - plugins/rabbitmq/rabbitmq_connections # at t/test.t line 64. #+END_EXAMPLE -** TODO not ok 536 - plugins/network/multi_tcp_ping: perl syntax check +*** TODO not ok 538 - plugins/network/ldap_connections - threads… - -#+BEGIN_EXAMPLE -# Failed test 'plugins/network/multi_tcp_ping: perl syntax check' -# at t/test.t line 169. -# -# Command: perl -cw multi_tcp_ping -# -# STDOUT: -# -# -# -# STDERR: -# -# This Perl not built to support threads -# Compilation failed in require at multi_tcp_ping line 75. -# BEGIN failed--compilation aborted at multi_tcp_ping line 75. -# -# -#+END_EXAMPLE - -** TODO not ok 538 - plugins/network/ldap_connections - - False positive at 'ESTABLISHED$"'. + False positive in checkbashisms at 'ESTABLISHED$"'. Still, quite horrible shell code. @@ -144,15 +143,18 @@ not ok 2 - checkbashisms # Looks like you failed 1 test of 2. #+END_EXAMPLE -** TODO not ok 572 - plugins/network/d-link-dir-655-router-statistics-plugin: ruby syntax check - - No idea + +** [0/1] Blame the CI provider + +*** TODO not ok 536 - plugins/network/multi_tcp_ping: perl syntax check + + Perl on travis-ci not built to support threads #+BEGIN_EXAMPLE -# Failed test 'plugins/network/d-link-dir-655-router-statistics-plugin: ruby syntax check' +# Failed test 'plugins/network/multi_tcp_ping: perl syntax check' # at t/test.t line 169. # -# Command: ruby -cw d-link-dir-655-router-statistics-plugin +# Command: perl -cw multi_tcp_ping # # STDOUT: # @@ -160,8 +162,9 @@ not ok 2 - checkbashisms # # STDERR: # -# /home/travis/.rvm/rubies/ruby-1.9.3-p547/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- auto_gem (LoadError) -# from /home/travis/.rvm/rubies/ruby-1.9.3-p547/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_require.rb:54:in `require' +# This Perl not built to support threads +# Compilation failed in require at multi_tcp_ping line 75. +# BEGIN failed--compilation aborted at multi_tcp_ping line 75. # # #+END_EXAMPLE