Robot/contrib-munin
2
0
Fork 0
mirror of https://github.com/munin-monitoring/contrib.git synced 2018-11-08 00:59:34 +01:00
Code Issues Releases Wiki Activity

[http_load_] Fix issue with long domain name

Browse Source 
Munin 1.0 supports fieldnames of at most 19 characters. For domain names
longer than that, this plugin simply truncate the names in its own cache
down to 19.

This creates an issue with the `response` graph, which appends the HTTP
status code to the hostname to make multiple variables. Truncating to
this string loses this information, leading to an empty graph.

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
This commit is contained in:
Olivier Mehani 2017-01-07 16:28:13 +11:00
parent 2bb6892e9e
commit ec0df0719d
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
plugins/http/http_load_
View File

@ -170,15 +170,24 @@ sub get_cache_file_name{
return $file; return $file;
} }
# Get fieldname (making sure it is munin "compatible" as a fieldname) # Get fieldname (making sure it is munin-1.0 "compatible" as a fieldname)
# 1. Remove all non-word characters from a string) # 1. Remove all non-word characters from a string)
# 2. Make sure it has maximum 19 characters # 2. Make sure it has maximum 19 characters
# 2.1 If not, truncate the host part, while keeping anything after an underscore (e.g., HTTP response status)
sub get_fieldname{ sub get_fieldname{
my $url=$_[0]; my $url=$_[0];
$url =~ s/\W//g; $url =~ s/\W//g;
if(length($url) > 19){ if(length($url) > 19){
$url =~ s/(\S+)_(\S+)/ /g;
my $host = $1;
my $info = $2;
my $suffixlength = length($info) + 1;
if ($suffixlength > 1) {
$url = substr($host, 0, 19 - $suffixlength) . '_' . $info;
} else {
$url = substr($url, 0, 19); $url = substr($url, 0, 19);
} }
}
return $url; return $url;
} }