Merge pull request #905 from sumpfralle/tests-executable-flag

Test for executable permission bits. Fix many plugins with missing permission bit. Closes: #787 Closes: #904
2018-11-08 00:59:34 +01:00 · 2018-03-09 00:42:32 +01:00 · 2018-03-09 00:42:32 +01:00 · f28acdd8d7
commit f28acdd8d7
parent 29e6f53cad 7c62b9b6de
98 changed files with 8 additions and 1 deletions
--- a/plugins/accounting/accounting_
+++ b/plugins/accounting/accounting_
--- a/plugins/apache/apache_average_time_last_n_requests
+++ b/plugins/apache/apache_average_time_last_n_requests
--- a/plugins/apache/apache_byprojects/byprojects_access
+++ b/plugins/apache/apache_byprojects/byprojects_access
--- a/plugins/apache/apache_byprojects/byprojects_bandwidth
+++ b/plugins/apache/apache_byprojects/byprojects_bandwidth
--- a/plugins/apache/apache_byprojects/byprojects_inout_bandwidth
+++ b/plugins/apache/apache_byprojects/byprojects_inout_bandwidth
--- a/plugins/apache/apache_vhosts/apache_logparser
+++ b/plugins/apache/apache_vhosts/apache_logparser
--- a/plugins/apache/apache_vhosts/apache_pipelogger
+++ b/plugins/apache/apache_vhosts/apache_pipelogger
--- a/plugins/apache/apache_vhosts/apache_vhosts
+++ b/plugins/apache/apache_vhosts/apache_vhosts
--- a/plugins/apache/page_load
+++ b/plugins/apache/page_load
--- a/plugins/arp/arp_bsd_
+++ b/plugins/arp/arp_bsd_
--- a/plugins/dhcp/dhcpd-pools
+++ b/plugins/dhcp/dhcpd-pools
--- a/plugins/disk/btrfs_subvol_usage
+++ b/plugins/disk/btrfs_subvol_usage
--- a/plugins/disk/e2
+++ b/plugins/disk/e2
--- a/plugins/disk/hdsentinel
+++ b/plugins/disk/hdsentinel
--- a/plugins/disk/quota2percent_
+++ b/plugins/disk/quota2percent_
--- a/plugins/djabberd/djabberd_
+++ b/plugins/djabberd/djabberd_
--- a/plugins/dovecot/dovecot_stats_
+++ b/plugins/dovecot/dovecot_stats_
--- a/plugins/drupal/drupal_page_speed_test.php
+++ b/plugins/drupal/drupal_page_speed_test.php
--- a/plugins/dvb/2wcomdsr_
+++ b/plugins/dvb/2wcomdsr_
--- a/plugins/freeradius/freeradius_queue
+++ b/plugins/freeradius/freeradius_queue
--- a/plugins/games/game
+++ b/plugins/games/game
--- a/plugins/glassfish/glassfish_counters_
+++ b/plugins/glassfish/glassfish_counters_
--- a/plugins/icecast/icecast2_
+++ b/plugins/icecast/icecast2_
--- a/plugins/icecast/icecast2_all
+++ b/plugins/icecast/icecast2_all
--- a/plugins/jchkmail/jchkmail_counters_
+++ b/plugins/jchkmail/jchkmail_counters_
--- a/plugins/jenkins/jenkins_
+++ b/plugins/jenkins/jenkins_
--- a/plugins/mail/postfwd-rbl
+++ b/plugins/mail/postfwd-rbl
--- a/plugins/mediawiki/mediawiki_api
+++ b/plugins/mediawiki/mediawiki_api
--- a/plugins/memcached/memcached_servers_
+++ b/plugins/memcached/memcached_servers_
--- a/plugins/minecraft/bukkit-jsonapi-players
+++ b/plugins/minecraft/bukkit-jsonapi-players
--- a/plugins/minecraft/bukkit-jsonapi-ramusage
+++ b/plugins/minecraft/bukkit-jsonapi-ramusage
--- a/plugins/minecraft/bukkit-jsonapi-tps
+++ b/plugins/minecraft/bukkit-jsonapi-tps
--- a/plugins/minecraft/bukkit-statistician-killshostile
+++ b/plugins/minecraft/bukkit-statistician-killshostile
--- a/plugins/minecraft/bukkit-statistician-killsneutral
+++ b/plugins/minecraft/bukkit-statistician-killsneutral
--- a/plugins/minecraft/bukkit-statistician-killspassive
+++ b/plugins/minecraft/bukkit-statistician-killspassive
--- a/plugins/minecraft/bukkit-statistician-players
+++ b/plugins/minecraft/bukkit-statistician-players
--- a/plugins/minecraft/bukkit-ultrabans-shame
+++ b/plugins/minecraft/bukkit-ultrabans-shame
--- a/plugins/minecraft/minecraft-users-ram_
+++ b/plugins/minecraft/minecraft-users-ram_
--- a/plugins/mongodb/mongo_collection_
+++ b/plugins/mongodb/mongo_collection_
--- a/plugins/moodle/moodle_files
+++ b/plugins/moodle/moodle_files
--- a/plugins/moodle/moodle_logs
+++ b/plugins/moodle/moodle_logs
--- a/plugins/moodle/moodle_mod_chat
+++ b/plugins/moodle/moodle_mod_chat
--- a/plugins/moodle/moodle_mod_forum
+++ b/plugins/moodle/moodle_mod_forum
--- a/plugins/moodle/moodle_mod_quiz
+++ b/plugins/moodle/moodle_mod_quiz
--- a/plugins/moodle/moodle_modules_total
+++ b/plugins/moodle/moodle_modules_total
--- a/plugins/moodle/moodle_users_online
+++ b/plugins/moodle/moodle_users_online
--- a/plugins/moodle/moodle_users_total
+++ b/plugins/moodle/moodle_users_total
--- a/plugins/mysql/hs_read
+++ b/plugins/mysql/hs_read
--- a/plugins/mysql/hs_write
+++ b/plugins/mysql/hs_write
--- a/plugins/network/ddclient
+++ b/plugins/network/ddclient
--- a/plugins/network/multibandwidth
+++ b/plugins/network/multibandwidth
--- a/plugins/network/ubiquiti_airfiber_
+++ b/plugins/network/ubiquiti_airfiber_
--- a/plugins/network/ubiquiti_airos_
+++ b/plugins/network/ubiquiti_airos_
--- a/plugins/nfs-freebsd/nfs_client
+++ b/plugins/nfs-freebsd/nfs_client
--- a/plugins/nfs-freebsd/nfs_client_cache
+++ b/plugins/nfs-freebsd/nfs_client_cache
--- a/plugins/percona/percona_
+++ b/plugins/percona/percona_
--- a/plugins/pf/pf_tables_
+++ b/plugins/pf/pf_tables_
--- a/plugins/php/php_errors_
+++ b/plugins/php/php_errors_
--- a/plugins/php/php_opcache.php
+++ b/plugins/php/php_opcache.php
--- a/plugins/php/php_time_execution
+++ b/plugins/php/php_time_execution
--- a/plugins/postgresql/postgres_tuplesratio_
+++ b/plugins/postgresql/postgres_tuplesratio_
--- a/plugins/power/eatonups_
+++ b/plugins/power/eatonups_
--- a/plugins/power/upsmonpro_
+++ b/plugins/power/upsmonpro_
--- a/plugins/printer/snmp__hpclj
+++ b/plugins/printer/snmp__hpclj
--- a/plugins/prosody/prosody_
+++ b/plugins/prosody/prosody_
--- a/plugins/puma/puma_
+++ b/plugins/puma/puma_
--- a/plugins/rackspace/rackspace_cdn_count.php
+++ b/plugins/rackspace/rackspace_cdn_count.php
--- a/plugins/rackspace/rackspace_cdn_size.php
+++ b/plugins/rackspace/rackspace_cdn_size.php
--- a/plugins/rethinkdb/rethinkdb_node_io
+++ b/plugins/rethinkdb/rethinkdb_node_io
--- a/plugins/riak/riak_fsm_time_95
+++ b/plugins/riak/riak_fsm_time_95
--- a/plugins/router/snmp__cisco_sbs_cpu
+++ b/plugins/router/snmp__cisco_sbs_cpu
--- a/plugins/sabnzbd/sabnzbd_dataleft
+++ b/plugins/sabnzbd/sabnzbd_dataleft
--- a/plugins/sabnzbd/sabnzbd_speed
+++ b/plugins/sabnzbd/sabnzbd_speed
--- a/plugins/security/fail2ban_
+++ b/plugins/security/fail2ban_
--- a/plugins/senderscore/senderscore
+++ b/plugins/senderscore/senderscore
--- a/plugins/sendmail/sendmail_mailq
+++ b/plugins/sendmail/sendmail_mailq
--- a/plugins/sensors/voltcraft_tcm220_
+++ b/plugins/sensors/voltcraft_tcm220_
--- a/plugins/sge/sge_queue_xml_
+++ b/plugins/sge/sge_queue_xml_
--- a/plugins/smf/smf_errors
+++ b/plugins/smf/smf_errors
--- a/plugins/smf/smf_mail_queue
+++ b/plugins/smf/smf_mail_queue
--- a/plugins/smf/smf_online
+++ b/plugins/smf/smf_online
--- a/plugins/smf/smf_stats
+++ b/plugins/smf/smf_stats
--- a/plugins/snmp/snmp__airport
+++ b/plugins/snmp/snmp__airport
--- a/plugins/snmp/snmp__cyberpower
+++ b/plugins/snmp/snmp__cyberpower
--- a/plugins/synology/snmp__synology_hddtemp
+++ b/plugins/synology/snmp__synology_hddtemp
--- a/plugins/synology/snmp__synology_temperature
+++ b/plugins/synology/snmp__synology_temperature
--- a/plugins/synology/snmp__synology_ups
+++ b/plugins/synology/snmp__synology_ups
--- a/plugins/syslog/syslog_ng_stats
+++ b/plugins/syslog/syslog_ng_stats
--- a/plugins/unicorn/unicorn_
+++ b/plugins/unicorn/unicorn_
--- a/plugins/uwsgi/uwsgi_
+++ b/plugins/uwsgi/uwsgi_
--- a/plugins/varnish/varnish4_
+++ b/plugins/varnish/varnish4_
--- a/plugins/vbulletin/vbulletin4_users
+++ b/plugins/vbulletin/vbulletin4_users
--- a/plugins/virtualbox/virtualbox_cpu_kernel
+++ b/plugins/virtualbox/virtualbox_cpu_kernel
--- a/plugins/virtualbox/virtualbox_cpu_user
+++ b/plugins/virtualbox/virtualbox_cpu_user
--- a/plugins/virtualbox/virtualbox_ram_usage
+++ b/plugins/virtualbox/virtualbox_ram_usage
--- a/plugins/voldemort/voldemort
+++ b/plugins/voldemort/voldemort
--- a/plugins/wordpress/wordpress2
+++ b/plugins/wordpress/wordpress2
--- a/t/test.t
+++ b/t/test.t
@ -48,7 +48,14 @@ sub process_file {
    my ( $file, $filename, $interpreter, $arguments ) = @_;
    use v5.10.1;

-    if ( $interpreter =~ m{/bin/sh} ) {
+    if ( ! -x $file ) {
+        # missing executable flag
+        diag(
+            sprintf("\nFile '%s' lacks executable permission bits. Maybe try 'chmod +x $file'?\n",
+                    $file)
+        );
+    }
+    elsif ( $interpreter =~ m{/bin/sh} ) {
        subtest $filename => sub {
            plan tests => 2;
            run_check(