2
0
mirror of https://github.com/munin-monitoring/contrib.git synced 2018-11-08 00:59:34 +01:00
Commit Graph

66 Commits

Author SHA1 Message Date
Lars Kruse
9cef55a3ed Restructure incomplete or broken "autoconf" implementations
Some plugins with non-zero autoconf exitcodes (it must be zero instead)
deserved a bit of code cleanup for improved readability.
2018-09-16 15:17:14 +02:00
Lars Kruse
e4cd049b01 Fix trivial instances of wrong autoconf exitcodes 2018-09-16 04:03:31 +02:00
Lars Kruse
17f784270a Whitespace cleanup
* remove trailing whitespace
* remove empty lines at the end of files
2018-08-02 02:33:25 +02:00
Wanpeng Qian
8ccf6e8ef4 change dependency from gawk to awk 2018-06-13 12:01:04 +09:00
Lars Kruse
c81c20ab3b unify DIRTYCONFIG handling in shell and python plugins
The following issues were fixed:
* comparison too broad (e.g. "0" misinterpreted as "true")
* python: comparing string with number (is never equal in python)
* unwanted non-zero exitcode (compound command "&&" as last command in
  shell code block (e.g. "case" or "if" branch))
* access to unset variable (shell style issue)
2018-04-07 02:17:06 +02:00
Lars Kruse
c4c73eae4c zfs_usage_: explain the slash/underscore substitutions
see 608a2a5ad7
2018-03-09 03:55:41 +01:00
sumpfralle
413f7c444d
Merge pull request #875 from yoe/patch-1
Allow for _ in original dataset name
2018-03-09 03:48:16 +01:00
Lars Kruse
277730393d zpool_iostat: fix 'checkbashisms' issue
It was not a shell syntax problem - but just a checkbashisms issue.
2018-03-08 04:26:29 +01:00
Wouter Verhelst
608a2a5ad7 Allow for _ in original dataset name
The current code escapes / (which is legal as part of a dataset name for ZFS, but illegal as part of a munin graph name) into _ (which is legal for both). The result is that any _ characters in the original filename get changed into / in the legend, which is confusing.

Fix by escaping any existing _ characters into __ first, and then later replacing // into _ again. // is a sequence that will not occur in a ZFS dataset name, so any double-/ sequence must therefore have been a _ originally.
2017-09-18 13:56:29 +02:00
sumpfralle
61b6e28539 Merge pull request #867 from shakemid/add_zpool_cap
Add zpool_capacity plugin
2017-08-15 20:12:22 +02:00
K.Cima
b2acd0514d Fix for pullreq #867 2017-08-14 12:04:00 +09:00
K.Cima
3f0af3802a Add zpool_capacity plugin 2017-08-04 17:05:12 +09:00
K.Cima
a6b505540f Add illumos, FreeBSD, Linux support for zfs_arcstats plugin, cleanup code 2017-08-04 16:52:48 +09:00
Lars Kruse
e384268157 [zpool_iostat] added example graphs (by @Rayziltl) 2017-07-22 16:02:25 +02:00
Lars Kruse
14fae65757 [zpool_iostat] keep previous fieldnames 2017-07-22 16:02:25 +02:00
Lars Kruse
aa9a39f043 [zpool_iostat] improve formatting and variable names 2017-07-22 16:02:25 +02:00
Lars Kruse
2ad0dfec78 [zpool_iostat] fix whitespace issues 2017-07-22 16:02:25 +02:00
Lars Kruse
0e5e9cbdfb [zpool_iostat] use backward compatible fieldnames 2017-07-22 16:02:25 +02:00
Lars Kruse
dd9cf0c0b9 [zpool_iostat] change category from 'filesystem' to 'disk' 2017-07-22 16:02:25 +02:00
Lars Kruse
7b2cefa45d [zpool_iostat] add POD documentation 2017-07-22 16:01:45 +02:00
Lars Kruse
77b9a515a5 [zpool_iostat] enable 'exit_on_error' and 'exit_on_unset' via 'set -eu' 2017-07-22 16:01:45 +02:00
Lars Kruse
3e86f2b80a [zpool_iostat] use 'clean_fieldname' and separate function 'get_pool_iostat'
FIeldnames possibly started with a digit before.
Closes: #779
2017-07-22 16:01:45 +02:00
Lars Kruse
9640be3646 [zpool_iostat] remove usage of temporary file 2017-07-22 16:01:45 +02:00
Lars Kruse
64c30de05f [zpool_iostat] autoconf checks zpool executable 2017-07-22 16:01:45 +02:00
Lars Kruse
67af152b9e [zpool_iostat] fix shellcheck warnings 2017-07-22 16:01:45 +02:00
Lars Kruse
806a9172f4 [zpool_iostat] switch from bash to sh 2017-07-22 16:01:45 +02:00
dipohl
65652aa0bd Category Tree: Reduce number of categories
ceph, samba, zfs into "fs"
apache into "webserver"
lighttpd into "webserver"
..
2017-02-21 22:15:07 +01:00
dipohl
2202b1c19e Category Tree: Reduce number of categories 2017-02-20 23:35:10 +01:00
Peter Doherty
4f0a708dfd Pass over empty lines in the arcstats
https://github.com/munin-monitoring/contrib/issues/680
2016-11-13 08:56:45 -05:00
Peter Doherty
50537fa5b9 improved readability, and eliminate a grep 2016-10-19 22:53:23 -04:00
Peter Doherty
45e7dea7a1 If a pool is named something like "m" or "ra" or any string that matches the types of zpool, the grep will match multiple lines.
Adding a space after the zlabel will allow for more exact matching.
2016-10-19 22:53:23 -04:00
Lutz Reinhardt
90c4727a61 Update zfs-filesystem-graph: using env
with env the script is running with linux and bsd
2015-10-27 19:28:42 +01:00
amichel
c147534385 Change interpreter to bash, [[ is just better 2015-05-16 01:59:27 -07:00
Adam Michel
26cac8f856 Forgot to use abstracted variables for stat files 2015-05-15 17:36:57 -07:00
Adam Michel
940fe45145 Refactor of variable assignment method 2015-05-15 17:28:14 -07:00
amichel
7f928fb5fb Re-submit zfsonlinux_stats_ 2015-05-15 10:16:14 -07:00
Stig Sandbeck Mathisen
2fa45511c6 Merge pull request #563 from elfurbe/zfs_list
Zfs list
2015-05-05 13:48:36 +02:00
Stig Sandbeck Mathisen
c39ff9fe6d Merge pull request #562 from elfurbe/zfsonlinux_stats_
Added zfsonlinux_stats plugin
2015-05-05 13:48:16 +02:00
Wouter Verhelst
9fd750dfc4 zfs-filesystem-graph: remove --upper-limit
Providing a --upper-limit parameter is only useful if the size of the
filesystem never changes. On ZFS, this assumption is only true for the
zpool; for all other filesystems, the available space is shared, and the
totalled values will vary. When this is the case, the --upper-limit
parameter will obscure peaks in the graph.
2015-04-15 23:53:38 +02:00
Veres Lajos
fba800ae52 typofixes - https://github.com/vlajos/misspell_fixer
Suspicious sections:
plugins/mail/postfix_mail_stats		recieved.label
plugins/nginx/nginx_vhost_traffic
2015-03-02 11:51:38 +00:00
amichel
7c3490ba2b Trying to make this into a one file commit. :| 2014-12-25 13:30:21 -07:00
amichel
cb6c9595eb Added zfs_list plugin 2014-12-25 13:23:05 -07:00
amichel
189fffebb4 Added zfsonlinux_stats plugin 2014-12-24 17:19:23 -07:00
Gabriele Pohl
6ffd50195c Reduce number of categories, use more generic terms 2014-09-07 02:03:45 +02:00
Tuxis Internet Engineering
1bf1090901 Add support for ZFS On Linux 2013-12-16 10:55:35 +01:00
Stig Sandbeck Mathisen
cde121726f Clean fieldnames, to allow filesystems and pools containing "-" to be graphed. 2013-07-14 19:04:44 +02:00
Stig Sandbeck Mathisen
fe35abf5c0 Use perl from $PATH in zfs_usage_ plugin 2013-07-14 19:04:44 +02:00
Steve Schnepp
7bd75f1bfb Merge pull request #299 from claudius23/zfs_usage_
plugins/zfs/zfs_usage_ add environment variables, call zfs binary only once
2013-05-07 02:25:58 -07:00
Claudius
947313b675 plugins/zfs/zfs_usage_ add environment variables, call zfs binary only once 2013-05-07 03:16:51 +02:00
tsaavik
2771a20fcb fixed duplicate value when read/write values == 0 2013-03-13 15:36:19 -07:00