Robot
/
croc
mirror of https://github.com/schollz/croc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: accidentally overwritten error value 

In function _cli.send_ the named return value 'err' gets accidentally
overwritten in the deferred anonymous function that removes the
files/directories. Renamed the error variable inside the deferred
function so that it does not overwrite the original error anymore.

Closes #296
This commit is contained in:
Niko Köser 2021-02-01 10:34:06 +01:00
parent 493eb075f1
commit 3ccd4d07e9
No known key found for this signature in database
GPG Key ID: F3F28C118DAA6375
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/cli/cli.go
View File

@ -223,9 +223,9 @@ func send(c *cli.Context) (err error) {
return
}
defer func() {
err = os.Remove(fnames[0])
if err != nil {
log.Error(err)
e := os.Remove(fnames[0])
if e != nil {
log.Error(e)
}
}()
} else if c.String("text") != "" {
@ -234,9 +234,9 @@ func send(c *cli.Context) (err error) {
return
}
defer func() {
err = os.Remove(fnames[0])
if err != nil {
log.Error(err)
e := os.Remove(fnames[0])
if e != nil {
log.Error(e)
}
}()