08fcd7ce59
Make --changed-within/before work for directories
...
closes #470
2019-09-15 17:03:23 +02:00
641594c2c6
Use regex::bytes::* instead of regex::*
2019-09-15 16:47:38 +02:00
2545aaabd2
Exit immediately when Ctrl-C has been pressed twice
2019-09-15 13:06:03 +02:00
a0505bd4df
Expose exit status from `--exec-batch <cmd>`
...
closes #333
2019-09-13 23:05:35 +02:00
5cbd8405ec
Check the pattern before anything else, since it doesn't require metadata
...
This should partially address #432 by decreasing the number of stat() calls:
$ strace -c -f ./fd-before '\.h$' /usr -j1 -S +1k >/dev/null
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
15.71 8.831948 7 1192279 46059 stat
$ strace -c -f ./fd-after '\.h$' /usr -j1 -S +1k >/dev/null
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
7.92 1.972474 10 183907 46046 stat
Though it's not as few as possible:
$ strace -c -f find /usr -iname '*.h' -size +1k >/dev/null
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
19.01 0.946500 5 161649 newfstatat
$ strace -c -f bfs /usr -iname '*.h' -size +1k >/dev/null
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
13.73 0.406565 5 69005 statx
Performance is much better when metadata is required:
$ hyperfine ./fd-{before,after}" '\.h$' /usr -j1 -S +1k"
Benchmark #1 : ./fd-before '\.h$' /usr -j1 -S +1k
Time (mean ± σ): 4.623 s ± 0.154 s [User: 1.465 s, System: 3.354 s]
Range (min … max): 4.327 s … 4.815 s 10 runs
Benchmark #2 : ./fd-after '\.h$' /usr -j1 -S +1k
Time (mean ± σ): 2.650 s ± 0.058 s [User: 1.258 s, System: 1.592 s]
Range (min … max): 2.568 s … 2.723 s 10 runs
Summary
'./fd-after '\.h$' /usr -j1 -S +1k' ran
1.74 ± 0.07 times faster than './fd-before '\.h$' /usr -j1 -S +1k'
While remaining the same when it's not:
$ hyperfine ./fd-{before,after}" '\.h$' /usr -j1"
Benchmark #1 : ./fd-before '\.h$' /usr -j1
Time (mean ± σ): 2.382 s ± 0.038 s [User: 1.221 s, System: 1.286 s]
Range (min … max): 2.325 s … 2.433 s 10 runs
Benchmark #2 : ./fd-after '\.h$' /usr -j1
Time (mean ± σ): 2.362 s ± 0.034 s [User: 1.193 s, System: 1.294 s]
Range (min … max): 2.307 s … 2.422 s 10 runs
Summary
'./fd-after '\.h$' /usr -j1' ran
1.01 ± 0.02 times faster than './fd-before '\.h$' /usr -j1'
2019-05-08 07:28:47 -05:00
c2b46f247f
avoid cloning command, in the wake of 9d26b74
2019-01-30 20:42:43 +01:00
fe53af064b
fix most clippy lints
2019-01-26 16:15:48 +01:00
6aa87f3423
save one indent level in error handling for add_ignore
2019-01-26 16:15:48 +01:00
74e593c43c
inline value used only once
2019-01-26 16:15:48 +01:00
df4227c614
Uniform names for config and wants_to_quit. Pass Arc's by ref.
2019-01-26 16:15:48 +01:00
5ade72a5e1
split spawn_receiver(..) and spawn_senders(..) from scan(..).
...
This is just a split commit, refraining from renaming too much.
The drop(tx) call is no longer necessary, as the first sender
is dropped at the end of spawn_senders(..)
2019-01-26 16:15:48 +01:00
8cfdcf43f6
Lock stdout only once
2019-01-09 08:20:20 +01:00
051ff5987a
[2018 edition] remove all extern crate lines from sources
2019-01-07 12:52:30 +01:00
64e6ea9fe9
[2018 edition] run cargo fix edition and edition-idioms
2019-01-07 12:52:30 +01:00
6b40a075cd
exec-batch: fix a panic with -X "echo {}" and pass stdio to child cmd
2018-11-12 21:11:40 +01:00
45d1b15cff
Add support for batch execution of command
2018-11-12 21:11:40 +01:00
f064ee5509
Properly use .ignore files, see #156
2018-10-27 18:11:50 +02:00
81a27fa9bd
Unify error messages, closes #342
2018-10-27 16:30:29 +02:00
6ff58abb6c
Re-enable .ignore files, closes #156
2018-10-27 15:42:02 +02:00
095bad550f
Print errors when --verbose is set
2018-10-23 21:50:25 +02:00
e2bb932f87
Doc: add chinese readme link ( #347 )
2018-10-19 22:05:15 +02:00
8543ca645d
Split internals.rs into module and multiple files
...
This PR splits `internals.rs` into the `internal` module with multiple
files, and moves `FdOptions` into `opts.rs`.
The main motivation behind this is to move logic for constructing
`FdOptions` out of the main function and more readable and easier to
understand in the `opts` module. The goal will eventually to be able
to write `FdOptions::from(matches)` and have the options constructed.
2018-10-12 19:14:19 +02:00
984f04f142
Add print_error macros to replace functions
...
This patch replaces the `print_error` and `print_error_and_exit`
functions with equivalent macros.
2018-10-12 07:31:21 +02:00
abe8aa55c0
clean-up first implementation of modification date filter
2018-10-10 19:52:37 +02:00
54c117d72f
Add support for --changed-before and --changed-with for modification time based search
2018-10-10 19:52:37 +02:00
cb1cfa108b
ErrorCode enum variants to be more descriptive
2018-10-03 16:06:18 +02:00
8bdd8f8e8f
Move exit code consts into enum
...
Previously, the constants defined in `src/exit_codes` weren't being
used, and the constants for exit codes were being redefined in the
`internals` module.
This PR removes the exit code consts and instead uses an enum defined in
`src/exit_codes`. This centralizes the definitions of exit codes making
them easier to modify and keep track of.
2018-10-03 16:06:18 +02:00
f9c4e8d399
refactor: loosen strict handling of missing --ignore-file
2018-10-03 13:11:51 +02:00
046b0574dc
Rename error => print_error_and_exit and introduce print_error
2018-10-01 22:00:23 +02:00
6407dc4eb4
chore: format code via rustfmt
2018-10-01 22:00:23 +02:00
2ebef2d46f
feat: enable display of error messages
2018-10-01 22:00:23 +02:00
27caa33729
cargo fmt
2018-09-27 23:01:38 +02:00
aa70c5a446
Add `--type empty`
...
Add a new `empty`/`e` type to search for empty files and/or directories.
To search for both empty files and directories, use one of the
following:
fd --type empty
fd -te
fd --type empty --type file --type directory
To search for empty files, use
fd --type empty --type file
fd -te -tf
To search for empty directories, use
fd --type empty --type directory
fd -te -td
closes #273
2018-08-19 17:05:04 +02:00
50a2bab5cd
Use short-circuiting for `--type` searches
...
Reverses the order of boolean checks for `--type` searches,
making them about 10% to 50% faster(!).
2018-08-19 16:27:23 +02:00
641976cf7a
Remove duplicated `lstat` syscall
...
Removes a unnecessary `lstat` syscall by calling `.metadata()` only
once. This makes `--type executable` searches about 15% faster.
2018-08-19 16:23:06 +02:00
c1ef68662c
Update for new rustfmt
2018-05-14 21:00:00 +02:00
4172ed03f0
Do not include non-files when using --size
2018-04-25 23:08:05 +02:00
2f3b472dfd
Changes from review
2018-04-25 08:14:12 +02:00
0207c1371e
Initial impl of size constraints.
...
This adds find-style size constraints with + or - indicating greater
or less than, a numerical size, and a unit
2018-04-25 08:14:12 +02:00
6a9f16e159
Run latest version of rustfmt
2018-04-13 23:13:22 +02:00
37483036e0
Implement --ignore-file
2018-03-26 08:28:22 +02:00
f9a32583a5
Move is_executable to fshelper module
2018-03-25 19:48:09 +02:00
2cf8e7b8a5
Move is_executable to internal module
2018-03-25 18:37:50 +02:00
67f6fdf6a7
Code formating
2018-03-25 16:53:12 +02:00
8ce127e443
changed executable=> executable_only
2018-03-25 16:53:12 +02:00
b1e48efc4a
Addresses #246
...
Some implementation to search by filetype `executables`
2018-03-25 16:53:12 +02:00
5397787824
Skip fifos, sockets, .. when using --type f/d/l
2018-03-15 21:38:52 +01:00
47d95284aa
Skip invalid utf8 filenames, closes #250
2018-02-26 08:20:31 +01:00
631931b431
Only construct entry_path if needed
2018-02-25 18:17:11 +01:00
40d811c7be
Rewrite of file-type filtering leading to 5% speed-up
2018-02-25 18:17:11 +01:00
sharkdp
Tavian Barnes
Alexandru Macovei
kimsnj
Park Juhyung
yobrave
Josh Leeb-du Toit
Karim SENHAJI
psinghal20
Steve Pentland
Pramod Bisht