Robot
/
node-gamedig
mirror of https://github.com/gamedig/node-gamedig.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat: dns: Use node's built in isIP check instead of regex (#410) 

Fixes #408
This commit is contained in:
Tom 2023-11-19 19:02:55 +00:00 committed by GitHub
parent f4150b2324
commit bdb926d6b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/DnsResolver.js
View File

@ -1,4 +1,5 @@
import dns from 'node:dns'
import { isIP } from 'node:net'
import punycode from 'punycode/punycode.js'
export default class DnsResolver {
@ -9,12 +10,12 @@ export default class DnsResolver {
this.logger = logger
}
isIp (host) {
return !!host.match(/\d+\.\d+\.\d+\.\d+/)
}
/**
* Response port will only be present if srv record was involved.
* Resolve a host name to its IP, if the given host name is already
* an IP address no request is made.
*
* If a srvRecordPrefix is provided a SRV request will be made and the
* port returned will be included in the output.
* @param {string} host
* @param {number} ipFamily
* @param {string=} srvRecordPrefix
@ -23,7 +24,8 @@ export default class DnsResolver {
async resolve (host, ipFamily, srvRecordPrefix) {
this.logger.debug('DNS Lookup: ' + host)
if (this.isIp(host)) {
// Check if host is IPv4 or IPv6
if (isIP(host) === 4 || isIP(host) === 6) {
this.logger.debug('Raw IP Address: ' + host)
return { address: host }
}