Robot
/
node-gamedig
mirror of https://github.com/gamedig/node-gamedig.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

minecraft: Split vanilla string by bytes instead of characters (#436) 

The received string length from server is expected to be a byte length
whereas if we parse to string first javascript will treat our length as
a character length (accounts for UTF multi-byte characters).

This should hopefully fix #434
This commit is contained in:
Tom 2023-12-17 00:13:08 +00:00 committed by GitHub
parent ec33bc2ca2
commit dcc69a36b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
protocols/minecraftvanilla.js
View File

@ -39,7 +39,9 @@ export default class minecraftvanilla extends Core {
const strLen = reader.varint()
this.logger.debug('String Length: ' + strLen)
const str = reader.rest().toString('utf8')
const rest = reader.rest()
const str = rest.toString('utf8', 0, strLen)
this.logger.debug(str)
const json = JSON.parse(str.substring(0, strLen))
@ -61,8 +63,8 @@ export default class minecraftvanilla extends Core {
// Better Compatibility Checker mod support
let bccJson = {}
if (str.length > strLen) {
const bccStr = str.substring(strLen + 1)
if (rest.length > strLen) {
const bccStr = rest.toString('utf8', strLen + 1)
bccJson = JSON.parse(bccStr)
}