Robot
/
watchexec
mirror of https://github.com/watchexec/watchexec.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Log fs watch/unwatch errors harder (to reveal paths)

This commit is contained in:
Félix Saparelli 2021-08-23 05:15:55 +12:00
parent 6cb3fc1c9a
commit 3588cb4d62
No known key found for this signature in database
GPG Key ID: B948C4BAE44FC474
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/src/fs.rs
View File

@ -7,7 +7,7 @@ use std::{
use notify::Watcher as _;
use tokio::sync::{mpsc, watch};
use tracing::{debug, trace};
use tracing::{debug, error, trace};
use crate::{
error::{CriticalError, RuntimeError},
@ -157,6 +157,7 @@ pub async fn worker(
for path in to_drop {
trace!(?path, "removing path from the watcher");
if let Err(err) = w.unwatch(&path) {
error!(?err, "notify unwatch() error");
errors
.send(RuntimeError::FsWatcherPathRemove {
path,
@ -172,6 +173,7 @@ pub async fn worker(
for path in to_watch {
trace!(?path, "adding path to the watcher");
if let Err(err) = w.watch(&path, notify::RecursiveMode::Recursive) {
error!(?err, "notify watch() error");
errors
.send(RuntimeError::FsWatcherPathAdd {
path,
@ -179,6 +181,7 @@ pub async fn worker(
err,
})
.await?;
// TODO: unwatch and re-watch manually while ignoring all the erroring paths
} else {
pathset.insert(path);
}