Review TODOs in the code

lib/src/action.rs

@@ -226,7 +226,7 @@ async fn apply_outcome(
 					.handle(post_spawn)
 					.map_err(|e| rte("action post-spawn", e))?;
 
-				// TODO: consider what we want to do for processes still running here?
+				// TODO: consider what we want to do for (previous) process if it's still running here?
 				*process = Some(sup);
 			}
 		}

lib/src/error.rs

@@ -186,7 +186,6 @@ pub enum RuntimeError {
 
 		#[source]
 		err: Box<dyn std::error::Error + Send + Sync>,
-		// FIXME: can we have dyn Diagnostic here or downcast it somehow?
 	},
 }
 

lib/src/filter/tagged.rs

@@ -185,7 +185,6 @@ impl TaggedFilterer {
 		origin: impl Into<PathBuf>,
 		workdir: impl Into<PathBuf>,
 	) -> Result<Arc<Self>, TaggedFiltererError> {
-		// TODO: make it criticalerror
 		Ok(Arc::new(Self {
 			origin: canonicalize(origin.into())?,
 			workdir: canonicalize(workdir.into())?,
@@ -396,7 +395,7 @@ pub struct Filter {
 }
 
 impl Filter {
-	// TODO non-unicode matching
+	// TODO: non-unicode matching
 	pub fn matches(&self, subject: impl AsRef<str>) -> Result<bool, TaggedFiltererError> {
 		let subject = subject.as_ref();
 

lib/src/fs.rs

@@ -213,6 +213,7 @@ pub async fn worker(
 						errors.send(e).await?;
 					}
 				// TODO: unwatch and re-watch manually while ignoring all the erroring paths
+				// See https://github.com/watchexec/watchexec/issues/218
 				} else {
 					pathset.insert(path);
 				}

lib/src/signal.rs

@@ -163,7 +163,6 @@ async fn imp_worker(
 }
 
 // TODO: figure out how to prioritise signals.
-// TODO: also, figure out why event processing is stalling when the channel limit is reached (when there are lots of fs events).
 async fn send_event(
 	errors: mpsc::Sender<RuntimeError>,
 	events: mpsc::Sender<Event>,