Allow non-UTF8 input for paths and extensions (#349)

- Fixes #345 (second crash)
- Proper fix instead of #347

crates/cli/src/args.rs

@@ -34,7 +34,8 @@ pub fn get_args(tagged_filterer: bool) -> Result<ArgMatches> {
 			.value_name("path")
 			.number_of_values(1)
 			.multiple_occurrences(true)
-			.takes_value(true))
+			.takes_value(true)
+			.allow_invalid_utf8(true))
 		.arg(Arg::new("clear")
 			.help_heading(Some(OPTSET_OUTPUT))
 			.help("Clear screen before executing command")
@@ -81,7 +82,8 @@ pub fn get_args(tagged_filterer: bool) -> Result<ArgMatches> {
 			.help("Write debugging messages to file in JSON format (use for bug reports)")
 			.long("log-file")
 			.takes_value(true)
-			.value_name("path"))
+			.value_name("path")
+			.allow_invalid_utf8(true))
 		.arg(Arg::new("print-events")
 			.help_heading(Some(OPTSET_DEBUGGING))
 			.help("Print events that trigger actions")
@@ -159,12 +161,14 @@ pub fn get_args(tagged_filterer: bool) -> Result<ArgMatches> {
 			.help_heading(Some(OPTSET_FILTERING))
 			.help("Override the project origin: the directory from which ignore files are detected")
 			.value_name("path")
-			.long("project-origin"))
+			.long("project-origin")
+			.allow_invalid_utf8(true))
 		.arg(Arg::new("command-workdir")
 			.help_heading(Some(OPTSET_COMMAND))
 			.help("Change the working directory of the command")
 			.value_name("path")
-			.long("workdir"))
+			.long("workdir")
+			.allow_invalid_utf8(true))
 		.arg(Arg::new("command-env")
 			.help_heading(Some(OPTSET_COMMAND))
 			.help("Add an environment variable to the command")
@@ -195,7 +199,8 @@ pub fn get_args(tagged_filterer: bool) -> Result<ArgMatches> {
 				.number_of_values(1)
 				.multiple_occurrences(true)
 				.takes_value(true)
-				.value_name("path"),
+				.value_name("path")
+				.allow_invalid_utf8(true),
 		)
 		.arg(
 			Arg::new("no-global-filters")
@@ -216,7 +221,8 @@ pub fn get_args(tagged_filterer: bool) -> Result<ArgMatches> {
 				.help("Comma-separated list of file extensions to watch (e.g. js,css,html)")
 				.short('e')
 				.long("exts")
-				.takes_value(true),
+				.takes_value(true)
+				.allow_invalid_utf8(true),
 		)
 		.arg(
 			Arg::new("filter")

crates/cli/src/filterer/common.rs

@@ -18,7 +18,7 @@ pub async fn dirs(args: &ArgMatches) -> Result<(PathBuf, PathBuf)> {
 		.into_diagnostic()?;
 	debug!(?curdir, "current directory");
 
-	let project_origin = if let Some(origin) = args.value_of("project-origin") {
+	let project_origin = if let Some(origin) = args.value_of_os("project-origin") {
 		debug!(?origin, "project origin override");
 		canonicalize(origin).into_diagnostic()?
 	} else {

crates/cli/src/main.rs

@@ -37,7 +37,7 @@ async fn main() -> Result<()> {
 
 	{
 		let verbosity = args.occurrences_of("verbose");
-		let log_file = if let Some(file) = args.value_of("log-file") {
+		let log_file = if let Some(file) = args.value_of_os("log-file") {
 			Some(File::create(file).into_diagnostic()?)
 		} else {
 			None